[
https://issues.apache.org/jira/browse/ARTEMIS-2434?focusedWorklogId=283453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283453
]
ASF GitHub Bot logged work on ARTEMIS-2434:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jul/19 16:27
Start Date: 26/Jul/19 16:27
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2771: ARTEMIS-2434 Don't
lock ServerConsumerImpl for long period of time
URL: https://github.com/apache/activemq-artemis/pull/2771#issuecomment-515517273
I have yet to verify that it works good on our CI: the only downside of this
solution is that the lock won't be fairly attempted on `tryLock` if compared
with an explicit timed `lock`.
I don't think this would be a problem, given that `setStarted` and
`setTransferring` are slow path operations (ie rollback and connection
transfert) and will be performend at least 300 times (every 100 ms for 30
seconds), the chance that they won't enter the lock is very small.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 283453)
Time Spent: 20m (was: 10m)
> Don't lock ServerConsumerImpl for long period of time
> -----------------------------------------------------
>
> Key: ARTEMIS-2434
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2434
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ServerConsumerImpl::lockDelivery is always being called while holding the
> ServerConsumerImpl::lock and it would prevent ServerConsumerImpl::handle to
> proceed, making afterAck/afterRollback operations unable to acquire the
> QueueImpl monitor, holded while awating ServerConsumerImpl::handle.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
