[
https://issues.apache.org/jira/browse/AMQNET-596?focusedWorklogId=292518&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-292518
]
ASF GitHub Bot logged work on AMQNET-596:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/19 13:30
Start Date: 10/Aug/19 13:30
Worklog Time Spent: 10m
Work Description: Havret commented on pull request #15: AMQNET-596: Added
local message expiry connection uri connection property
URL: https://github.com/apache/activemq-nms-amqp/pull/15#discussion_r312696052
##########
File path: src/NMS.AMQP/NmsConnectionFactory.cs
##########
@@ -99,6 +99,11 @@ private IdGenerator ConnectionIdGenerator
}
}
+ /// <summary>
+ /// Enables local message expiry for all MessageConsumers under the
connection. Default is true.
+ /// </summary>
+ public bool IsLocalMessageExpiry { get; set; } = true;
Review comment:
To keep things consistent with qpid implementation I would rename this
property to `LocalMessageExpiry`.
https://qpid.apache.org/releases/qpid-jms-0.44.0/docs/index.html
We are using this property name to parse options from conneciton uri, thus
following string will not not be parsed correctly:
`nms.localMessageExpiry=false`.
As for now we have rather poor docs, it would make better sense to keep
options adjacent to qpid as their docs will be treated as reference by our
users. At least at first.
Not sure what to do with other places (`ConnectionInfo`, `ConsumerInfo`).
It's rather up to you. I personally like to have things consistent from top to
bottom.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 292518)
Time Spent: 50m (was: 40m)
> Support LocalMessageExpiry property for NMS AMQP
> ------------------------------------------------
>
> Key: AMQNET-596
> URL: https://issues.apache.org/jira/browse/AMQNET-596
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: AMQP, NMS
> Reporter: Chris Morgan
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Qpid Jms has a connection property to Enable/Disable LocalMessageExpiry. The
> nms amqp provider should support this property as some amqp brokers do not
> support LocalMessageExpiry at the protocol level over amqp.
>
> This property should be added to the NmsConnectionFactory, along with the
> ConnectionInfo Class and the ConsumerInfo Class and applied at consumer
> message receive.
>
> The default value in qpid jms is true to have the nms amqp provider should
> have the same default.
>
> The string name of the property will be "nms.localMessagePriority".
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
