[ https://issues.apache.org/jira/browse/ARTEMIS-2453?focusedWorklogId=295505&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295505 ]
ASF GitHub Bot logged work on ARTEMIS-2453: ------------------------------------------- Author: ASF GitHub Bot Created on: 15/Aug/19 15:40 Start Date: 15/Aug/19 15:40 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2799: ARTEMIS-2453 Fixing deadLock between destroyQueue and removeAddressInfo URL: https://github.com/apache/activemq-artemis/pull/2799#discussion_r314370749 ########## File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/PostOfficeImpl.java ########## @@ -649,9 +647,7 @@ public AddressInfo removeAddressInfo(SimpleString address, boolean force) throws @Override public AddressInfo getAddressInfo(SimpleString addressName) { - synchronized (addressLock) { - return addressManager.getAddressInfo(addressName); - } + return addressManager.getAddressInfo(addressName); Review comment: @jbertram thanks.. that confirms what I thought. I'm running the whole testsuite to confirm it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 295505) Time Spent: 50m (was: 40m) > DeadLock between server.destroyQueue and server.removeAddressInfo > ----------------------------------------------------------------- > > Key: ARTEMIS-2453 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2453 > Project: ActiveMQ Artemis > Issue Type: Bug > Reporter: clebert suconic > Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > "Thread-0 > (ActiveMQ-remoting-threads-ActiveMQServerImpl::serverUUID=349ac51e-bf5e-11e9-9661-ecf4bbced624-2058174333)": > at > org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.getAddressInfo(PostOfficeImpl.java:652) > - waiting to lock <0x00000005be7a5488> (a java.lang.Object) at > org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:749) > - locked <0x00000005bb0702c8> (a > org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962) > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2142) > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2090) > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2081) > at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.destroyQueue(ActiveMQServerImpl.java:2061) > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.run(ServerSessionImpl.java:986) > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1001) > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl$TempQueueCleanerUpper.connectionFailed(ServerSessionImpl.java:1006) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:77) > at > org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:220) > at > org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:220) > at > org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.issueFailure(RemotingServiceImpl.java:572) > at > org.apache.activemq.artemis.core.remoting.server.impl.RemotingServiceImpl.connectionDestroyed(RemotingServiceImpl.java:553) > at > org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor$Listener.connectionDestroyed(NettyAcceptor.java:897) > at > org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler.lambda$channelInactive$0(ActiveMQChannelHandler.java:83) > at > org.apache.activemq.artemis.core.remoting.impl.netty.ActiveMQChannelHandler$$Lambda$56/1250509089.run(Unknown > Source) at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > at > org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown > Source) at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > "Thread-1 > (ActiveMQ-server-org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl$6@4a55a6e8)": > at > org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeBinding(PostOfficeImpl.java:724) > - waiting to lock <0x00000005bb0702c8> (a > org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl) at > org.apache.activemq.artemis.core.server.impl.QueueImpl.deleteQueue(QueueImpl.java:1962) > at > org.apache.activemq.artemis.core.postoffice.impl.PostOfficeImpl.removeAddressInfo(PostOfficeImpl.java:631) > - locked <0x00000005be7a5488> (a java.lang.Object) at > org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.removeAddressInfo(ActiveMQServerImpl.java:3231) > at > org.apache.activemq.artemis.core.management.impl.ActiveMQServerControlImpl.deleteAddress(ActiveMQServerControlImpl.java:866) > at sun.reflect.GeneratedMethodAccessor94.invoke(Unknown Source) at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) at > org.apache.activemq.artemis.core.server.management.impl.ManagementServiceImpl.invokeOperation(ManagementServiceImpl.java:787) > at > org.apache.activemq.artemis.core.server.management.impl.ManagementServiceImpl.handleMessage(ManagementServiceImpl.java:415) > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.handleManagementMessage(ServerSessionImpl.java:1913) > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1682) > - locked <0x0000000595951730> (a > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl) at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1623) > - locked <0x0000000595951730> (a > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl) at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1615) > at > org.apache.activemq.artemis.core.server.impl.ServerSessionImpl.send(ServerSessionImpl.java:1608) > at > org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onSessionSend(ServerSessionPacketHandler.java:702) > at > org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler.onMessagePacket(ServerSessionPacketHandler.java:268) > at > org.apache.activemq.artemis.core.protocol.core.ServerSessionPacketHandler$$Lambda$25/243781418.onMessage(Unknown > Source) at > org.apache.activemq.artemis.utils.actors.Actor.doTask(Actor.java:33) at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > at > org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown > Source) at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42) > at > org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31) > at > org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66) > at > org.apache.activemq.artemis.utils.actors.ProcessorBase$$Lambda$2/323326911.run(Unknown > Source) at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > at > org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118) > Found 1 deadlock. -- This message was sent by Atlassian JIRA (v7.6.14#76016)