[
https://issues.apache.org/jira/browse/AMQ-7258?focusedWorklogId=296740&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296740
]
ASF GitHub Bot logged work on AMQ-7258:
---------------------------------------
Author: ASF GitHub Bot
Created on: 17/Aug/19 06:05
Start Date: 17/Aug/19 06:05
Worklog Time Spent: 10m
Work Description: jbonofre commented on pull request #383: [AMQ-7258]
Update spring.schemas in activemq-osgi
URL: https://github.com/apache/activemq/pull/383#discussion_r314936200
##########
File path: activemq-osgi/src/main/resources/META-INF/spring.schemas
##########
@@ -67,21 +67,32 @@
http\://activemq.apache.org/schema/core/activemq-core-5.15.9.xsd=activemq.xsd
http\://camel.apache.org/schema/spring/camel-spring.xsd=camel-spring.xsd
-http\://www.springframework.org/schema/beans/spring-beans-2.0.xsd=org/springframework/beans/factory/xml/spring-beans-2.0.xsd
-http\://www.springframework.org/schema/beans/spring-beans-2.5.xsd=org/springframework/beans/factory/xml/spring-beans-2.5.xsd
-http\://www.springframework.org/schema/beans/spring-beans-3.0.xsd=org/springframework/beans/factory/xml/spring-beans-3.0.xsd
-http\://www.springframework.org/schema/beans/spring-beans-3.1.xsd=org/springframework/beans/factory/xml/spring-beans-3.1.xsd
-http\://www.springframework.org/schema/beans/spring-beans-3.2.xsd=org/springframework/beans/factory/xml/spring-beans-3.2.xsd
-http\://www.springframework.org/schema/beans/spring-beans.xsd=org/springframework/beans/factory/xml/spring-beans-3.2.xsd
-http\://www.springframework.org/schema/tool/spring-tool-2.0.xsd=org/springframework/beans/factory/xml/spring-tool-2.0.xsd
-http\://www.springframework.org/schema/tool/spring-tool-2.5.xsd=org/springframework/beans/factory/xml/spring-tool-2.5.xsd
-http\://www.springframework.org/schema/tool/spring-tool-3.0.xsd=org/springframework/beans/factory/xml/spring-tool-3.0.xsd
-http\://www.springframework.org/schema/tool/spring-tool-3.1.xsd=org/springframework/beans/factory/xml/spring-tool-3.1.xsd
-http\://www.springframework.org/schema/tool/spring-tool-3.2.xsd=org/springframework/beans/factory/xml/spring-tool-3.2.xsd
-http\://www.springframework.org/schema/tool/spring-tool.xsd=org/springframework/beans/factory/xml/spring-tool-3.2.xsd
-http\://www.springframework.org/schema/util/spring-util-2.0.xsd=org/springframework/beans/factory/xml/spring-util-2.0.xsd
-http\://www.springframework.org/schema/util/spring-util-2.5.xsd=org/springframework/beans/factory/xml/spring-util-2.5.xsd
-http\://www.springframework.org/schema/util/spring-util-3.0.xsd=org/springframework/beans/factory/xml/spring-util-3.0.xsd
-http\://www.springframework.org/schema/util/spring-util-3.1.xsd=org/springframework/beans/factory/xml/spring-util-3.1.xsd
-http\://www.springframework.org/schema/util/spring-util-3.2.xsd=org/springframework/beans/factory/xml/spring-util-3.2.xsd
-http\://www.springframework.org/schema/util/spring-util.xsd=org/springframework/beans/factory/xml/spring-util-3.2.xsd
+http\://www.springframework.org/schema/beans/spring-beans-2.0.xsd=org/springframework/beans/factory/xml/spring-beans.xsd
Review comment:
This is what I see in spring-beans:
```
jar tvf spring-beans-4.3.24.RELEASE.jar |grep -i xsd
44429 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-4.2.xsd
8612 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-4.3.xsd
41645 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-3.0.xsd
4341 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-4.2.xsd
4341 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-4.0.xsd
4341 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-4.3.xsd
7663 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-2.0.xsd
44429 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-4.3.xsd
8092 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-3.2.xsd
8092 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-3.1.xsd
38848 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-2.0.xsd
43993 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-3.2.xsd
4341 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-3.1.xsd
4345 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-3.0.xsd
2835 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-2.5.xsd
44429 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-4.1.xsd
4341 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-3.2.xsd
8612 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-4.1.xsd
2208 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-2.0.xsd
43193 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-4.0.xsd
8612 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-4.2.xsd
8092 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-4.0.xsd
8068 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-3.0.xsd
4341 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-tool-4.1.xsd
43399 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-3.1.xsd
42114 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-beans-2.5.xsd
8068 Thu May 09 08:43:48 CEST 2019
org/springframework/beans/factory/xml/spring-util-2.5.xsd
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 296740)
Time Spent: 50m (was: 40m)
> ActiveMQ does not start if Karaf is offline (SAXParseException)
> ---------------------------------------------------------------
>
> Key: AMQ-7258
> URL: https://issues.apache.org/jira/browse/AMQ-7258
> Project: ActiveMQ
> Issue Type: Bug
> Components: OSGi/Karaf
> Affects Versions: 5.15.9
> Environment: Karaf, Offline
> Reporter: Jonas
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.16.0, 5.15.10
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> To reproduce:
> - Download, unpack and start karaf 4.2.6
> feature:repo-add activemq
> feature:install activemq-broker
> ActiveMQ will start succesfully.
> Now stop karaf, go offline and start karaf again.
> This time the exception below can be found in the log and ActiveMQ fails to
> start.
> {code:java}
> Caused by:
> org.springframework.beans.factory.xml.XmlBeanDefinitionStoreException: Line
> 24 in XML document from URL
> [file:/Users/jkop/Downloads/apache-karaf-4.2.6/etc/activemq.xml] is invalid;
> nested exception is org.xml.sax.SAXParseException; lineNumber: 24;
> columnNumber: 101; cvc-elt.1: Cannot find the declaration of element 'beans'.
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.doLoadBeanDefinitions(XmlBeanDefinitionReader.java:404)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:336)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:304)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:188)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:224)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:195)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:257)
> ~[98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractXmlApplicationContext.loadBeanDefinitions(AbstractXmlApplicationContext.java:128)
> ~[99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractXmlApplicationContext.loadBeanDefinitions(AbstractXmlApplicationContext.java:94)
> ~[99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractRefreshableApplicationContext.refreshBeanFactory(AbstractRefreshableApplicationContext.java:133)
> ~[99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractApplicationContext.obtainFreshBeanFactory(AbstractApplicationContext.java:636)
> ~[99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:521)
> ~[99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.apache.activemq.osgi.ActiveMQServiceFactory.updated(ActiveMQServiceFactory.java:126)
> ~[59:org.apache.activemq.activemq-osgi:5.15.9]
> ... 7 more
> org.xml.sax.SAXParseException: schema_reference.4: Failed to read schema
> document 'http://www.springframework.org/schema/beans/spring-beans.xsd',
> because 1) could not find the document; 2) the document could not be read; 3)
> the root element of the document is not <xsd:schema>.
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:203)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.warning(ErrorHandlerWrapper.java:99)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:392)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLErrorReporter.reportError(XMLErrorReporter.java:306)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.reportSchemaErr(XSDHandler.java:4158)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.reportSchemaWarning(XSDHandler.java:4149)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.getSchemaDocument1(XSDHandler.java:2491)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.getSchemaDocument(XSDHandler.java:2193)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.parseSchema(XSDHandler.java:578)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaLoader.loadSchema(XMLSchemaLoader.java:610)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaValidator.findSchemaGrammar(XMLSchemaValidator.java:2447)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaValidator.handleStartElement(XMLSchemaValidator.java:1768)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.XMLSchemaValidator.startElement(XMLSchemaValidator.java:741)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.scanStartElement(XMLNSDocumentScannerImpl.java:374)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl$NSContentDriver.scanRootElementHook(XMLNSDocumentScannerImpl.java:613)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl$FragmentContentDriver.next(XMLDocumentFragmentScannerImpl.java:3132)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl$PrologDriver.next(XMLDocumentScannerImpl.java:852)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentScannerImpl.next(XMLDocumentScannerImpl.java:602)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLNSDocumentScannerImpl.next(XMLNSDocumentScannerImpl.java:112)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:505)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:842)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:771)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:243)
> [?:?]
> at
> com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:339)
> [?:?]
> at
> org.springframework.beans.factory.xml.DefaultDocumentLoader.loadDocument(DefaultDocumentLoader.java:77)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.doLoadDocument(XmlBeanDefinitionReader.java:434)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.doLoadBeanDefinitions(XmlBeanDefinitionReader.java:392)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:336)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.xml.XmlBeanDefinitionReader.loadBeanDefinitions(XmlBeanDefinitionReader.java:304)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:188)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:224)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:195)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.beans.factory.support.AbstractBeanDefinitionReader.loadBeanDefinitions(AbstractBeanDefinitionReader.java:257)
> [98:org.apache.servicemix.bundles.spring-beans:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractXmlApplicationContext.loadBeanDefinitions(AbstractXmlApplicationContext.java:128)
> [99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractXmlApplicationContext.loadBeanDefinitions(AbstractXmlApplicationContext.java:94)
> [99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractRefreshableApplicationContext.refreshBeanFactory(AbstractRefreshableApplicationContext.java:133)
> [99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractApplicationContext.obtainFreshBeanFactory(AbstractApplicationContext.java:636)
> [99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:521)
> [99:org.apache.servicemix.bundles.spring-context:5.1.7.RELEASE_1]
> at
> org.apache.activemq.osgi.ActiveMQServiceFactory.updated(ActiveMQServiceFactory.java:126)
> [59:org.apache.activemq.activemq-osgi:5.15.9]
> at
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
> [9:org.apache.felix.configadmin:1.9.14]
> at
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
> [9:org.apache.felix.configadmin:1.9.14]
> at
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1248)
> [9:org.apache.felix.configadmin:1.9.14]
> at
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1192)
> [9:org.apache.felix.configadmin:1.9.14]
> at org.apache.felix.cm.impl.UpdateThread.run0(UpdateThread.java:138)
> [9:org.apache.felix.configadmin:1.9.14]
> at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:105)
> [9:org.apache.felix.configadmin:1.9.14]
> at java.lang.Thread.run(Thread.java:748) [?:?]
> Caused by: java.net.UnknownHostException: www.springframework.org
> at
> java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:184)
> ~[?:?]
> at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) ~[?:?]
> at java.net.Socket.connect(Socket.java:589) ~[?:?]
> at java.net.Socket.connect(Socket.java:538) ~[?:?]
> at sun.net.NetworkClient.doConnect(NetworkClient.java:180) ~[?:?]
> at sun.net.www.http.HttpClient.openServer(HttpClient.java:463) ~[?:?]
> at sun.net.www.http.HttpClient.openServer(HttpClient.java:558) ~[?:?]
> at sun.net.www.http.HttpClient.<init>(HttpClient.java:242) ~[?:?]
> at sun.net.www.http.HttpClient.New(HttpClient.java:339) ~[?:?]
> at sun.net.www.http.HttpClient.New(HttpClient.java:357) ~[?:?]
> at
> sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1226)
> ~[?:?]
> at
> sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1162)
> ~[?:?]
> at
> sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1056)
> ~[?:?]
> at
> sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:990)
> ~[?:?]
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1570)
> ~[?:?]
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1498)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:647)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVersion(XMLVersionDetector.java:148)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.opti.SchemaParsingConfig.parse(SchemaParsingConfig.java:583)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.opti.SchemaParsingConfig.parse(SchemaParsingConfig.java:686)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.opti.SchemaDOMParser.parse(SchemaDOMParser.java:530)
> ~[?:?]
> at
> com.sun.org.apache.xerces.internal.impl.xs.traversers.XSDHandler.getSchemaDocument(XSDHandler.java:2181)
> ~[?:?]
> ... 39 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)