[
https://issues.apache.org/jira/browse/AMQNET-602?focusedWorklogId=296902&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-296902
]
ASF GitHub Bot logged work on AMQNET-602:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/19 09:32
Start Date: 18/Aug/19 09:32
Worklog Time Spent: 10m
Work Description: Havret commented on pull request #20: AMQNET-602: Set
batchable flag to false for amqp transfer
URL: https://github.com/apache/activemq-nms-amqp/pull/20
This PR resolves the performance issue with brokers that respect the
batchable flag for amqp transfer.
https://github.com/apache/activemq-nms-amqp/pull/8#issuecomment-517366025
It utilizes new Handel API of amqp net lite, and new testing toolkit, and
thus we should wait with merge until
https://github.com/Azure/amqpnetlite/commit/2c38af646de695c17ccccf6f6992fbeecd2a0252
is released and https://github.com/apache/activemq-nms-amqp/pull/9 is merged.
Moreover it illustrates the problem pointed out by @cjwmorgan-sol
https://github.com/apache/activemq-nms-amqp/pull/9#issuecomment-521632602.
Amqpnet lite sets settled flag to `true` for messages send in a fire and forget
manner. **TestSendingMessageNonPersistentSetsBatchableFalse** is failing
because of that. I think this issue should be addressed with higher precedence.
Prerequisites:
- [ ] amqpnetlite release,
- [ ] test toolkit merge
- [ ] settled issue solves for fire and forget sends
- [ ] rebase and history cleanup
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 296902)
Time Spent: 10m
Remaining Estimate: 0h
> Performance issue with brokers that respect batchable flag
> ----------------------------------------------------------
>
> Key: AMQNET-602
> URL: https://issues.apache.org/jira/browse/AMQNET-602
> Project: ActiveMQ .Net
> Issue Type: Improvement
> Components: AMQP, NMS
> Affects Versions: 1.8.0
> Reporter: Krzysztof Porebski
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> MessageProducer rate are 1 msg/sec on brokers that respect the batchable flag
> for amqp transfers. This has been a long standing issue with amqpnetlite
> until it was fixed for synchronous sends, version 2.1.8. The provider
> AmqpProducer uses async sends with ManualResetEvent to block. This is bad in
> term of amqp protocol as the transfer sent as batchable indicating to the
> broker that disposition should not be sent right away so it waits however the
> client is also waiting for a response leading to terrible message rates.
> Amqpnetlite fixed this issue at least for synchronous sends from a sender
> link where the batchable flag is set to false when a send is synchronous
> however that means that AmqpProducer must use a different send (see
> senderLink.send(msg) and senderLink.send(msg, timeout)) method then its
> currently using.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
