[
https://issues.apache.org/jira/browse/ARTEMIS-2450?focusedWorklogId=297234&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-297234
]
ASF GitHub Bot logged work on ARTEMIS-2450:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/19 16:01
Start Date: 19/Aug/19 16:01
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #2791:
ARTEMIS-2450 page-size-bytes should not be greater than Integer.MAX_VALUE
URL: https://github.com/apache/activemq-artemis/pull/2791#discussion_r315289774
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
##########
@@ -597,11 +597,11 @@ public void parseMainConfig(final Element e, final
Configuration config) throws
config.setJournalSyncNonTransactional(getBoolean(e,
"journal-sync-non-transactional", config.isJournalSyncNonTransactional()));
- config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size",
config.getJournalFileSize(), Validators.GT_ZERO));
+ config.setJournalFileSize(getTextBytesAsIntBytes(e, "journal-file-size",
config.getJournalFileSize(), Validators.POSITIVE_INT));
int journalBufferTimeout = getInteger(e, "journal-buffer-timeout",
config.getJournalType() == JournalType.ASYNCIO ?
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_AIO :
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_TIMEOUT_NIO, Validators.GE_ZERO);
- int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size",
config.getJournalType() == JournalType.ASYNCIO ?
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO :
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.GT_ZERO);
+ int journalBufferSize = getTextBytesAsIntBytes(e, "journal-buffer-size",
config.getJournalType() == JournalType.ASYNCIO ?
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_AIO :
ArtemisConstants.DEFAULT_JOURNAL_BUFFER_SIZE_NIO, Validators.POSITIVE_INT);
Review comment:
change was not needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 297234)
Time Spent: 3h 20m (was: 3h 10m)
> page-size-bytes should not be greater than Integer.MAX_VALUE
> ------------------------------------------------------------
>
> Key: ARTEMIS-2450
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2450
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Reporter: yangwei
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
