[ https://issues.apache.org/jira/browse/ARTEMIS-2483?focusedWorklogId=310075&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310075 ]
ASF GitHub Bot logged work on ARTEMIS-2483: ------------------------------------------- Author: ASF GitHub Bot Created on: 10/Sep/19 20:17 Start Date: 10/Sep/19 20:17 Worklog Time Spent: 10m Work Description: clebertsuconic commented on pull request #2833: ARTEMIS-2483 Sync calculation should use the block size URL: https://github.com/apache/activemq-artemis/pull/2833#discussion_r322942100 ########## File path: artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/util/SyncCalculation.java ########## @@ -77,7 +77,10 @@ public static long syncTest(File datafolder, int maxAIO, JournalType journalType) throws Exception { SequentialFileFactory factory = newFactory(datafolder, fsync, journalType, blockSize * blocks, maxAIO); - final boolean asyncWrites = journalType == JournalType.ASYNCIO && !syncWrites; + + if (factory instanceof AIOSequentialFileFactory) { + factory.setAlignment(blockSize); Review comment: Before anyone asks, I have no easy way to create a testcase for this. This is CLI, and hence this is like an UI tool. besides these defaults are dependent on platform, so I am on purpose not writing a testcase for this change. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 310075) Time Spent: 20m (was: 10m) > BlockSize is not used on sync calculation on CLI create > ------------------------------------------------------- > > Key: ARTEMIS-2483 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2483 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker > Affects Versions: 2.10.0 > Reporter: clebert suconic > Assignee: clebert suconic > Priority: Major > Fix For: 2.11.0 > > Time Spent: 20m > Remaining Estimate: 0h > > During an ./artemis create, the block size is not passed to libaio, letting > it use the default value from the device. > This is particularly dangerous as some MDS providers will return a huge block > size (e.g. ceph-fs). > instead we should always use 4K if calculation sync times on libaio. -- This message was sent by Atlassian Jira (v8.3.2#803003)