[ 
https://issues.apache.org/jira/browse/AMQNET-612?focusedWorklogId=311699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311699
 ]

ASF GitHub Bot logged work on AMQNET-612:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Sep/19 20:38
            Start Date: 12/Sep/19 20:38
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on issue #31: AMQNET-612: 
ObjectMessage shouldn't have jms-msg-type set
URL: https://github.com/apache/activemq-nms-amqp/pull/31#issuecomment-530996473
 
 
   The new check for serialized dotnet content type should never be true while 
the annotation is set to reflect a JMS Object Message, it would be an error if 
it were. That was the starting point of the discussion, that the client 
originally did that and should not.  Neither the NMS client or any other should 
set the annotation to that value along with a content type which is other than 
"application/x-java-serialized-object", so you cant positively check for the 
dotnet serialized case, only that it is "application/x-java-serialized-object" 
or that there is none set.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 311699)
    Time Spent: 5h 10m  (was: 5h)

> ObjectMessage shouldn't have jms-msg-type set
> ---------------------------------------------
>
>                 Key: AMQNET-612
>                 URL: https://issues.apache.org/jira/browse/AMQNET-612
>             Project: ActiveMQ .Net
>          Issue Type: Bug
>          Components: AMQP, NMS
>    Affects Versions: 1.8.0
>            Reporter: Krzysztof Porebski
>            Priority: Major
>          Time Spent: 5h 10m
>  Remaining Estimate: 0h
>
> From the mailing list:
> "I was having a look at the readme, which then lead to me having a poke
> around the repo for the ObjectMessage handling based on something I
> read. I think there may be an issue in the object message handling and
> would propose a change if its actually doing what some of the code
> suggests. I could be entirely wrong here though, I havent run it up to
> be sure as I dont have the environment or clue to do so, so thought
> I'd mention this here for now rather than e.g a JIRA.
> It appeared that the client will always set the x-opt-jms-msg-type
> annotation on messages, presumably with aim of increased
> interoperability with receiving JMS AMQP clients, which is generally
> fine (though the JMS client handles most cases without that through
> other means). However in the case of object messages it appeared like
> it might do so in a way that will specifically prevent interop at all
> by default. It looked like it will send a Data section with serialized
> object content and a "application/x-dotnet-serialized-object" content
> type, which all seems fine and expected, but it also looked like it
> will still set the x-opt-jms-msg-type value set for a JMS
> ObjectMessage type at the same time. It doesnt feel like that should
> be the case here, given the payload is known to be incompatible and
> the JMS client wont be able to return such content to an application.
> Omitting the annotation when sending such serialized dotnet message
> payload would allow it to be treated as a BytesMessage on a receiving
> JMS client (due to the unknown content type) and then at least the
> application could retrieve the raw payload and do what it likes with
> it." ??Robbie Gemmell ??



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to