[
https://issues.apache.org/jira/browse/ARTEMIS-2488?focusedWorklogId=314549&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314549
]
ASF GitHub Bot logged work on ARTEMIS-2488:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/19 18:25
Start Date: 18/Sep/19 18:25
Worklog Time Spent: 10m
Work Description: lulf commented on pull request #2834: ARTEMIS-2488:
Handle the case where source address is null
URL: https://github.com/apache/activemq-artemis/pull/2834#discussion_r325826961
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/test/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContextTest.java
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.protocol.amqp.proton;
+
+import org.apache.activemq.artemis.core.server.AddressQueryResult;
+import org.apache.activemq.artemis.protocol.amqp.broker.AMQPSessionCallback;
+import
org.apache.activemq.artemis.protocol.amqp.exceptions.ActiveMQAMQPNotFoundException;
+import org.apache.qpid.proton.amqp.messaging.Source;
+import org.apache.qpid.proton.engine.Sender;
+import org.junit.Test;
+
+import java.util.Collections;
+
+import static org.mockito.Mockito.*;
Review comment:
Fixed, sorry about that!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 314549)
Time Spent: 1h 10m (was: 1h)
> Potential NPE parsing source address in AMQP
> --------------------------------------------
>
> Key: ARTEMIS-2488
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2488
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Ulf Lilleengen
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
