[ https://issues.apache.org/jira/browse/ARTEMIS-2496?focusedWorklogId=314921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314921 ]
ASF GitHub Bot logged work on ARTEMIS-2496: ------------------------------------------- Author: ASF GitHub Bot Created on: 19/Sep/19 09:36 Start Date: 19/Sep/19 09:36 Worklog Time Spent: 10m Work Description: wy96f commented on issue #2843: ARTEMIS-2496 Revert catch up with zero-copy, as it's causing issues i… URL: https://github.com/apache/activemq-artemis/pull/2843#issuecomment-533051423 > Another thing I've noticed: before the revert, `ChunkedFile` wasn't working for me...do we have tests to verify it? @franz1981 There is no test. I copied the code https://github.com/netty/netty/blob/ff7a9fa091a8bf2e10020f83fc4df1c44098bbbb/example/src/main/java/io/netty/example/file/FileServerHandler.java#L52 `ChunkedFile` will read file into bytebuf which would then be written into socket channel, https://github.com/netty/netty/blob/ff7a9fa091a8bf2e10020f83fc4df1c44098bbbb/handler/src/main/java/io/netty/handler/stream/ChunkedWriteHandler.java#L242 It should work as the operations are general. What problem did you encounter with `ChunkedFile`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 314921) Time Spent: 1h 50m (was: 1h 40m) > Use of Netty FileRegion on ReplicationCatch is breaking wildfly integration > with artemis > ---------------------------------------------------------------------------------------- > > Key: ARTEMIS-2496 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2496 > Project: ActiveMQ Artemis > Issue Type: Bug > Affects Versions: 2.10.0 > Reporter: clebert suconic > Assignee: clebert suconic > Priority: Major > Fix For: 2.11.0 > > Time Spent: 1h 50m > Remaining Estimate: 0h > > This is of course an issue on Wildfly integration, but it seems something on > our recent changes is breaking replication on Wildfly. > My biggest concern is that it seems that paging catch up is silently failing > in our testsuite and some other issues are currently hidden. > Wildfly has an extra layer on top of Netty: > https://github.com/xnio/netty-xnio-transport/tree/0.1 > But the main thing here, is that it seems that are other issues within > Artemis. > For now I'm reverting the change from ARTEMIS-2336 > And we need more investigation to bring it back -- This message was sent by Atlassian Jira (v8.3.4#803005)