[
https://issues.apache.org/jira/browse/ARTEMIS-1811?focusedWorklogId=316068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316068
]
ASF GitHub Bot logged work on ARTEMIS-1811:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/19 06:10
Start Date: 21/Sep/19 06:10
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2844:
ARTEMIS-1811 NIO Seq File should use RandomAccessFile with heap buffers
URL: https://github.com/apache/activemq-artemis/pull/2844#discussion_r326849133
##########
File path:
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/nio/NIOSequentialFile.java
##########
@@ -173,6 +173,40 @@ public int read(final ByteBuffer bytes) throws Exception {
return read(bytes, null);
}
+ //On *nix platform is the size by which RandomAccessFile write/read are
performed using a
+ //stack-allocated copy of the java byte[]
Review comment:
And what about windows
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 316068)
Time Spent: 2h 10m (was: 2h)
> NIOSequentialFile should use RandomAccessFile with heap ByteBuffers
> -------------------------------------------------------------------
>
> Key: ARTEMIS-1811
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1811
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.5.0
> Reporter: Francesco Nigro
> Assignee: Francesco Nigro
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> JournalStorageManager::addBytesToLargeMessage and
> LargeServerMessageImpl::DecodingContext::encode are relying on the pooling of
> direct ByteBuffers performed internally by NIO.
> Those buffers are pooled until certain size limit (ie
> jdk.nio.maxCachedBufferSize, as shown on
> [https://bugs.openjdk.java.net/browse/JDK-8147468]) otherwise are freed right
> after the write succeed.
> If the property jdk.nio.maxCachedBufferSize isn't set, the direct buffers are
> always pooled regardless of the size, leading to OOM issues on high load of
> variable sized writes due to the amount of direct memory allocated and not
> released/late released.
> The proposed solutions are:
> # perform ad hoc direct ByteBuffer caching on the write path thanks to the
> read lock
> # replace the NIO SequentialFile usage and just use RandomAccessFile that
> provide the right API to append byte[] without creating additional native
> copies
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
