[
https://issues.apache.org/jira/browse/ARTEMIS-2500?focusedWorklogId=316682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316682
]
ASF GitHub Bot logged work on ARTEMIS-2500:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 13:52
Start Date: 23/Sep/19 13:52
Worklog Time Spent: 10m
Work Description: gaohoward commented on issue #2846: ARTEMIS-2500
CoreMessage doesn't make a ful copy of its props
URL: https://github.com/apache/activemq-artemis/pull/2846#issuecomment-534108542
I find there are 2 copy methods in LargeServerMessageImpl. One is copy()
which uses copy constructor. The other is copy(newId) which does not. If we can
use copy constructor in both copy methods then this PR is not necessary. In the
case the copyHeadersAndProperties() shall be removed because it can cause
subtle errors described above and hard to find.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316682)
Time Spent: 2h 10m (was: 2h)
> CoreMessage doesn't make a full copy of its props
> -------------------------------------------------
>
> Key: ARTEMIS-2500
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2500
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.10.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> When CoreMessage is doing copyHeadersAndProperties() it doesn't
> make a full copy of its properties (a TypedProperties object).
> It will cause problem when multiple threads/parties are modifying the
> properties of the copied messages from the same message.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
