[
https://issues.apache.org/jira/browse/AMQNET-616?focusedWorklogId=318135&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318135
]
ASF GitHub Bot logged work on AMQNET-616:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/19 08:15
Start Date: 25/Sep/19 08:15
Worklog Time Spent: 10m
Work Description: HavretGC commented on pull request #38: AMQNET-616: Add
TCP Keep-Alive support
URL: https://github.com/apache/activemq-nms-amqp/pull/38#discussion_r327987510
##########
File path: src/NMS.AMQP/Transport/SecureTransportContext.cs
##########
@@ -37,8 +37,8 @@ namespace Apache.NMS.AMQP.Transport
internal class SecureTransportContext : TransportContext,
ISecureTransportContext
{
- private readonly static List<string> SupportedProtocols;
- private readonly static Dictionary<string, int>
SupportedProtocolValues;
+ private static readonly List<string> SupportedProtocols;
Review comment:
It was static from the beginning. I've merely rearranged words order to
adjust it to current code style. From what I see from the code it's static as
it never changes. Some consts that are initialized in static constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 318135)
Time Spent: 0.5h (was: 20m)
> Add TCP Keep-Alive support
> --------------------------
>
> Key: AMQNET-616
> URL: https://issues.apache.org/jira/browse/AMQNET-616
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: AMQP
> Affects Versions: 1.8.0
> Reporter: Krzysztof Porebski
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It should be possible to enable TCP Keep-Alive option for underlying socket.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
