[
https://issues.apache.org/jira/browse/ARTEMIS-2504?focusedWorklogId=318211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318211
]
ASF GitHub Bot logged work on ARTEMIS-2504:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/19 10:17
Start Date: 25/Sep/19 10:17
Worklog Time Spent: 10m
Work Description: brusdev commented on pull request #2850: ARTEMIS-2504
implement retroactive addresses
URL: https://github.com/apache/activemq-artemis/pull/2850#discussion_r328041981
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java
##########
@@ -1971,7 +1988,9 @@ private synchronized int iterQueue(final int flushLimit,
if (filter1 == null || filter1.match(ref.getMessage())) {
messageAction.actMessage(tx, ref);
- iter.remove();
+ if (remove) {
Review comment:
Do we need the same check for scheduledDelivery messages
(https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ScheduledDeliveryHandlerImpl.java#L128)
and paged messages
(https://github.com/apache/activemq-artemis/blob/master/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L2002)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 318211)
Time Spent: 20m (was: 10m)
> Support retroactive addresses
> -----------------------------
>
> Key: ARTEMIS-2504
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2504
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
