[
https://issues.apache.org/jira/browse/AMQNET-620?focusedWorklogId=323865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323865
]
ASF GitHub Bot logged work on AMQNET-620:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/19 03:54
Start Date: 05/Oct/19 03:54
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #44:
AMQNET-620: Initialize ConnectionFactory properly with System.Uri overload
URL: https://github.com/apache/activemq-nms-amqp/pull/44#discussion_r331731333
##########
File path: src/NMS.AMQP/NmsConnectionFactory.cs
##########
@@ -58,7 +58,7 @@ public NmsConnectionFactory(string brokerUri)
public NmsConnectionFactory(Uri brokerUri)
{
- this.brokerUri = brokerUri;
+ this.BrokerUri = brokerUri;
Review comment:
Nit. But so is consistent with other constructors can the "this" be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 323865)
Time Spent: 20m (was: 10m)
> ConnectionFactory is not initialized properly with Uri overload
> ---------------------------------------------------------------
>
> Key: AMQNET-620
> URL: https://issues.apache.org/jira/browse/AMQNET-620
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: AMQP
> Reporter: Krzysztof Porebski
> Priority: Major
> Fix For: 1.8.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ConnectionFactory is not initialized properly with constructor that takes
> System.Uri as a parameter. Additional properties that are specified in broker
> uri (like username or password) are not applied on connection factory.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
