[ https://issues.apache.org/jira/browse/AMQNET-619?focusedWorklogId=323888&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323888 ]
ASF GitHub Bot logged work on AMQNET-619: ----------------------------------------- Author: ASF GitHub Bot Created on: 05/Oct/19 08:23 Start Date: 05/Oct/19 08:23 Worklog Time Spent: 10m Work Description: Havret commented on pull request #42: AMQNET-619: Handle remote detach properly for sender link URL: https://github.com/apache/activemq-nms-amqp/pull/42#discussion_r331738433 ########## File path: src/NMS.AMQP/Provider/Amqp/AmqpProducer.cs ########## @@ -53,13 +53,13 @@ public Task Attach() }; string linkName = info.Id + ":" + target.Address; - var taskCompletionSource = new TaskCompletionSource<bool>(); - senderLink = new SenderLink(session.UnderlyingSession, linkName, frame, (link, attach) => { taskCompletionSource.SetResult(true); }); + TaskCompletionSource<bool> tsc = new TaskCompletionSource<bool>(); Review comment: Hope it's ok now. 😳 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 323888) Time Spent: 50m (was: 40m) > Remote detach is not handled properly for sender link > ----------------------------------------------------- > > Key: AMQNET-619 > URL: https://issues.apache.org/jira/browse/AMQNET-619 > Project: ActiveMQ .Net > Issue Type: Bug > Components: AMQP > Reporter: Krzysztof Porebski > Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > > Remote detach is not handled properly for sender link. MessageProducer is > created even if no link terminus was created. It results in unexpected > behavior if we try to use MessageProducer immediately after its creation -- This message was sent by Atlassian Jira (v8.3.4#803005)