[ 
https://issues.apache.org/jira/browse/ARTEMIS-2466?focusedWorklogId=332621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332621
 ]

ASF GitHub Bot logged work on ARTEMIS-2466:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Oct/19 14:48
            Start Date: 23/Oct/19 14:48
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2868: 
ARTEMIS-2466 PageSyncTimer::timeSync isn't configurable using ASYNCIO
URL: https://github.com/apache/activemq-artemis/pull/2868#discussion_r338095867
 
 

 ##########
 File path: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/deployers/impl/FileConfigurationParser.java
 ##########
 @@ -675,6 +675,8 @@ public void parseMainConfig(final Element e, final 
Configuration config) throws
 
       
config.setCriticalAnalyzerPolicy(CriticalAnalyzerPolicy.valueOf(getString(e, 
"critical-analyzer-policy", config.getCriticalAnalyzerPolicy().name(), 
Validators.NOT_NULL_OR_EMPTY)));
 
+      config.setPageSyncTimeout(getInteger(e, "page-sync-timeout", 
config.getJournalBufferTimeout_NIO(), Validators.GE_ZERO));
 
 Review comment:
   I did not see any xsd changes.. or the FileConfiguration parser tests...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 332621)
    Time Spent: 20m  (was: 10m)

> PageSyncTimer::timeSync isn't configurable using ASYNCIO journal
> ----------------------------------------------------------------
>
>                 Key: ARTEMIS-2466
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2466
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.10.0
>            Reporter: Francesco Nigro
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> If the broker is configured to use ASYNCIO journal, PageSyncTimer::timeSync 
> is being defaulted with the default journal buffer timeout of NIO ie 3333333 
> or 300 writes/sec



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to