[
https://issues.apache.org/jira/browse/ARTEMIS-2526?focusedWorklogId=332786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-332786
]
ASF GitHub Bot logged work on ARTEMIS-2526:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/19 18:41
Start Date: 23/Oct/19 18:41
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #2869: ARTEMIS-2526 -
Update ActiveMQServerImpl to call correct beforeDestroyQueue hook
URL: https://github.com/apache/activemq-artemis/pull/2869#issuecomment-545581689
checkstyle as it stands now:
```
Note: Recompile with -Xlint:unchecked for details.
[ERROR]
src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerQueuePlugin.java:[60]
(regexp) RegexpSingleline: Line has trailing spaces.
[ERROR]
src/main/java/org/apache/activemq/artemis/core/server/plugin/ActiveMQServerQueuePlugin.java:[61]
(regexp) RegexpSingleline: Line has trailing spaces.
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on
project artemis-server: You have 2 Checkstyle violations. -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 332786)
Time Spent: 20m (was: 10m)
> ActiveMQServerQueuePlugin calls wrong beforeDestroyQueue method
> ---------------------------------------------------------------
>
> Key: ARTEMIS-2526
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2526
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.10.1
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This jira: ARTEMIS-2265 (federation) added a new callback for
> beforeDestroyQueue which gets implemented to handle removing a remote queue
> when the local queue is gone. However, the location in the broker that calls
> the plugin hook was not updated to use the new method. This means that
> consumers are not properly removed on Federated addresses.
> We need to fix the delegation, mark the old method as deprecated (like we do
> in other plugins) and then updated the plugin test to verify.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
