[
https://issues.apache.org/jira/browse/ARTEMIS-2541?focusedWorklogId=340142&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-340142
]
ASF GitHub Bot logged work on ARTEMIS-2541:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/19 20:33
Start Date: 07/Nov/19 20:33
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2886:
ARTEMIS-2541 Improve message browser of Admin UI
URL: https://github.com/apache/activemq-artemis/pull/2886#discussion_r343860424
##########
File path: artemis-hawtio/artemis-plugin/src/main/webapp/plugin/js/browse.js
##########
@@ -26,44 +26,55 @@ var ARTEMIS = (function(ARTEMIS) {
displayName: 'Message ID',
cellTemplate: '<div class="ngCellText"><a
ng-click="openMessageDialog(row)">{{row.entity.messageID}}</a></div>',
// for ng-grid
- width: '10%'
- }, {
- field: 'userID',
- displayName: 'User ID',
- width: '10%'
+ width: '100px'
}, {
field: 'type',
displayName: 'Type',
- width: '10%'
+ cellTemplate: '<div class="ngCellText"
title="{{row.entity.type}}">{{formatType(row.entity.type)}}</div>',
+ width: '90px'
}, {
field: 'durable',
displayName: 'Durable',
- width: '10%'
+ width: '70px'
}, {
field: 'priority',
displayName: 'Priority',
- width: '7%'
+ width: '70px'
}, {
field: 'timestamp',
displayName: 'Timestamp',
- width: '19%'
+ cellTemplate: '<div class="ngCellText"
title="{{row.entity.timestamp}}">{{formatTimestamp(row.entity.timestamp)}}</div>',
+ width: '160px'
}, {
field: 'expiration',
displayName: 'Expires',
- width: '10%'
+ cellTemplate: '<div class="ngCellText"
title="{{row.entity.expiration}}">{{formatExpires(row.entity.expiration)}}</div>',
+ width: '180px'
}, {
field: 'redelivered',
displayName: 'Redelivered',
- width: '10%'
+ width: '100px'
}, {
field: 'largeMessage',
displayName: 'Large',
- width: '10%'
+ width: '50px'
+ }, {
+ field: 'persistentSize',
+ displayName: 'Size',
+ cellTemplate: '<div class="ngCellText"
title="{{row.entity.persistentSize}}">{{formatPersistentSize(row.entity.persistentSize)}}</div>',
+ width: '100px'
+ }, {
+ field: 'userID',
+ displayName: 'User ID',
+ cellTemplate: '<div class="ngCellText">{{row.entity.userID ?
row.entity.userID : row.entity.StringProperties._AMQ_VALIDATED_USER}}</div>',
Review comment:
> @clebertsuconic I actually would prefer to show the _AMQ_VALIDATED_USER
value by default and falling back to userID if it is not present. WDYT?
would that be intuitive to users? shouldn't we keep it separated columns?
as long as users can understand the result without having to read any doc
about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 340142)
Time Spent: 1.5h (was: 1h 20m)
> Improve rendering in message browser of Admin UI
> ------------------------------------------------
>
> Key: ARTEMIS-2541
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2541
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Web Console
> Affects Versions: 2.10.1
> Reporter: Sebastian T
> Priority: Minor
> Attachments: ScreenShot.png, ScreenShot_BeforePR.png
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The accompanying PR improves the following parts of the Admin UI's message
> browser:
> # use fixed column width for columns with date/numeric/boolean values
> # move the *userID* column to the end and make it's width auto expand
> # the *userID* column now alternatively displays the *_AMQ_VALIDATED_USER*
> string property in case the userID field is empty. this e.g. is the case in
> our environment where we use client certificate based authentication.
> # display human readable names in the *type* column instead of numeric
> value. the numeric value is still accessible via a tooltip of the respective
> cell and used for sorting
> # The *expires* column displays a human friendly representation of the time
> when the message expires (or expired in case it was not yet GCed) instead of
> a unix timestamp.
> If the message expires in less than 24 hours the format "*In hh:mm:ss*" is
> used, otherwise the format is "*yyyy.mm.dd hh:mm:ss*" in the local user's
> timezone.
> The actual timestamp value with ms precision is still used when sorting the
> columns and is accessible via a cell tooltip.
> # The messages are now sortable by the *timestamp* column, as the server now
> sends the unix timestamp instead of an already pre-rendered datetime string
> in the server's locale
> # Add a new sortable column that displays the messages persistent size.
> Attached is a screenshot illustrating the changes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
