[
https://issues.apache.org/jira/browse/AMQNET-625?focusedWorklogId=344941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-344941
]
ASF GitHub Bot logged work on AMQNET-625:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/19 13:13
Start Date: 17/Nov/19 13:13
Worklog Time Spent: 10m
Work Description: Havret commented on issue #48: AMQNET-625: Content
Property of IBytesMessage should be idempotent
URL: https://github.com/apache/activemq-nms-amqp/pull/48#issuecomment-554744378
@michaelandrepearce Done. Moreover I've changed slightly the name of the
first test to make it more descriptive.
The other thing is that I am not sure what should be the expected behavior
of Content setter when somebody starts messing with Write* methods. Content
property is a peculiar thing for NMS IBytesMessage and there is no equivalent
of it in JMS API, thus it would be a futile attempt to look for inspiration in
qpid-jms, as I used to do to tackle previous problems.
My implementation mimics what was done in NMS MSMQ:
https://github.com/apache/activemq-nms-msmq/blob/b6d954d9a97f11459f1b34956aeae675e456dfdd/src/main/csharp/BaseMessage.cs#L42-L47
where Content Property circumvents all the bits related to Binary Writers
and Readers and exposes direct access to underlying message body.
@cjwmorgan-sol, @gemmellr, @michaelandrepearce What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 344941)
Time Spent: 40m (was: 0.5h)
> byte[] Content property of IBytesMessage is accessible only once
> ----------------------------------------------------------------
>
> Key: AMQNET-625
> URL: https://issues.apache.org/jira/browse/AMQNET-625
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: AMQP
> Reporter: Kamil Nowak
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> byte[] Content property of IBytesMessage is accessible only once. Further
> readings yield byte array with all zeroes assigned.
> *Steps to reproduce:*
> Put a breakpoint in a method which handles the upcoming messaging in the
> consumer. This results in a reading operation of the byte[] Content of a
> message of type IBytesMessage. Therefore, further reading operations yield
> the array with all elements having the '0' assigned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
