[ 
https://issues.apache.org/jira/browse/AMQ-7291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16978464#comment-16978464
 ] 

Frederic Kneier commented on AMQ-7291:
--------------------------------------

IMHO this definitively is a bug if the  ActiveMQBytesMessage allows to clear 
properties but not to set them afterwards.

It seems that the code  in ActiveMQBytesMessage.setObjectProperty checks for 
"readOnlyBody" while ActiveMQMessage.clearProperties is setting 
"readOnlyProperties".

 

In this case Zipkin is able to clear the properties but not to set them 
afterwards.

> Message body is read-only exception when setting property on Bytes message 
> ---------------------------------------------------------------------------
>
>                 Key: AMQ-7291
>                 URL: https://issues.apache.org/jira/browse/AMQ-7291
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>    Affects Versions: 5.x
>            Reporter: Jorge Esteban Quilcate Otoya
>            Priority: Major
>
> In [Zipkin's Brave instrumentation for JMS 
> clients|https://github.com/openzipkin/brave/tree/master/instrumentation/jms], 
> we are currently having issues on adding properties to ActiveMQ BytesMessage 
> <https://github.com/openzipkin/brave/issues/967>
>  
>  While setting String property on `ActiveMQMessage` works fine, setting 
> String property on `ActiveMQBytesMessage` throws "Message body is read-only 
> exception".
>  
> Checking the source code `ActiveMQMessage` only checks if properties are 
> read-only: 
> [https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/command/ActiveMQMessage.java#L493-L495]
>  
> While `ActiveMQBytesMessage` check if body is read-only when setting 
> property: 
> [https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/command/ActiveMQBytesMessage.java#L917]
>  calling 
> [https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/command/ActiveMQBytesMessage.java#L834]
>  
> Would love if someone can clarify if this is actually a bug and how to deal 
> with this scenario if it is not.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to