[
https://issues.apache.org/jira/browse/ARTEMIS-2571?focusedWorklogId=358300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358300
]
ASF GitHub Bot logged work on ARTEMIS-2571:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/19 05:19
Start Date: 12/Dec/19 05:19
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2913: ARTEMIS-2571 Remove
synchronization of ActiveMQServerImpl#getSessions()
URL: https://github.com/apache/activemq-artemis/pull/2913#issuecomment-564853817
@clebertsuconic I strongly suggest to use proper tools to get reliable
results ie JMH
I think
https://github.com/apache/qpid-proton-j/tree/master/tests/performance-jmh could
be a good way to start having some of them. On Netty there is already something
similar and JMH is not just for micro-benchmarks, but is ok for
macro-benchmarks too. Next week I can help to provide some useful examples on
that, if you agree :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 358300)
Time Spent: 2.5h (was: 2h 20m)
> Remove unneccessary synchronization in ActiveMQServerImpl
> ---------------------------------------------------------
>
> Key: ARTEMIS-2571
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2571
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker, Web Console
> Affects Versions: 2.10.1
> Reporter: Sebastian T
> Priority: Minor
> Attachments: artemis-test.zip
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> The ActiveMQServerImpl sessions field is a ConcurrentHashMap. Synchronizing
> on the ActiveMQServerImpl object to iterate over the map is not necessary.
> ActiveMQServerImpl#getSession, ActiveMQServerImpl#removeSession and
> ActiveMQServerImpl#createSession also work on the sessions field without
> synchronizing on the ActiveMQServerImpl.
> Removing the synchronized keyword on the ActiveMQServerImpl#getSessions()
> methods e.g. improves loading of Connections view, especially when multiple
> administrators are using the UI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
