[
https://issues.apache.org/jira/browse/ARTEMIS-2565?focusedWorklogId=359756&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359756
]
ASF GitHub Bot logged work on ARTEMIS-2565:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/19 03:14
Start Date: 14/Dec/19 03:14
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2903:
ARTEMIS-2565 - Add plugin support for Federated Queues/Addresses
URL: https://github.com/apache/activemq-artemis/pull/2903#issuecomment-565676333
@cshannon as you would have seen, two main bits to address here.
1) logging anything that is info, warn, error should always have a logging
code, and use a specific log method.
2) As plugins make things public, then interfaces should be extracted, so
plugin takes interface, not the concrete implementation. Also should only
expose what's needed e.g. getter fields methods, but maybe not every method?.
Else will make any future refactoring on concrete classes, like just done in
previous PR impossible.
Apart from that looks good. (thumbs up)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 359756)
Time Spent: 2h (was: 1h 50m)
> Add plugin support for Federated Queues/Addresses
> -------------------------------------------------
>
> Key: ARTEMIS-2565
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2565
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.10.1
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> In many cases it could be useful to have hooks for custom logic to be
> processed when using the Federated queue/address feature. This can be
> implemented using the plugin API via a new interface. This Jira is a start
> at adding in plugin methods but more can be added to the interface in the
> future plus we could have follow on Jiras to include some plugins (such as
> for metrics)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
