[ 
https://issues.apache.org/jira/browse/ARTEMIS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010310#comment-17010310
 ] 

Justin Bertram commented on ARTEMIS-2567:
-----------------------------------------

The first PR caused a problem on Windows 10 where this stack-trace is logged 
and the broker fails to start:

{noformat}
2020-01-04 21:36:10,726 ERROR [org.apache.activemq.artemis.core.server] 
AMQ224000: Failure in initialisation: java.io.IOException: The process cannot 
access the file because another process has locked a portion of the file 
 at sun.nio.ch.FileDispatcherImpl.pwrite0(Native Method) [rt.jar:1.8.0_25] 
 at sun.nio.ch.FileDispatcherImpl.pwrite(Unknown Source) [rt.jar:1.8.0_25] 
 at sun.nio.ch.IOUtil.writeFromNativeBuffer(Unknown Source) [rt.jar:1.8.0_25] 
 at sun.nio.ch.IOUtil.write(Unknown Source) [rt.jar:1.8.0_25] 
 at sun.nio.ch.FileChannelImpl.writeInternal(Unknown Source) [rt.jar:1.8.0_25] 
 at sun.nio.ch.FileChannelImpl.write(Unknown Source) [rt.jar:1.8.0_25] 
 at 
org.apache.activemq.artemis.core.server.impl.FileLockNodeManager.writeFileLockStatus(FileLockNodeManager.java:307)
 [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at 
org.apache.activemq.artemis.core.server.impl.FileLockNodeManager.setFailingBack(FileLockNodeManager.java:283)
 [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at 
org.apache.activemq.artemis.core.server.impl.FileLockNodeManager.startLiveNode(FileLockNodeManager.java:230)
 [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at 
org.apache.activemq.artemis.core.server.impl.LiveOnlyActivation.run(LiveOnlyActivation.java:70)
 [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at 
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.internalStart(ActiveMQServerImpl.java:600)
 [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at 
org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl.start(ActiveMQServerImpl.java:527)
 [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at 
org.apache.activemq.artemis.integration.FileBroker.start(FileBroker.java:70) 
[artemis-cli-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at org.apache.activemq.artemis.cli.commands.Run.execute(Run.java:84) 
[artemis-cli-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at org.apache.activemq.artemis.cli.Artemis.internalExecute(Artemis.java:150) 
[artemis-cli-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:98) 
[artemis-cli-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at org.apache.activemq.artemis.cli.Artemis.execute(Artemis.java:125) 
[artemis-cli-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT] 
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
[rt.jar:1.8.0_25] 
 at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) 
[rt.jar:1.8.0_25] 
 at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) 
[rt.jar:1.8.0_25] 
 at java.lang.reflect.Method.invoke(Unknown Source) [rt.jar:1.8.0_25] 
 at org.apache.activemq.artemis.boot.Artemis.execute(Artemis.java:129) 
[artemis-boot.jar:2.11.0-SNAPSHOT] 
 at org.apache.activemq.artemis.boot.Artemis.main(Artemis.java:49) 
[artemis-boot.jar:2.11.0-SNAPSHOT]{noformat}

I've sent another PR to deal with this issue.

 

> Shared-store failback broken on NFS
> -----------------------------------
>
>                 Key: ARTEMIS-2567
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2567
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.10.1
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>             Fix For: 2.11.0
>
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> The changes from ARTEMIS-2441 caused a regression of the issue fixed by 
> ARTEMIS-1417.
> The changes in ARTEMIS-1417 made sure to lock/unlock the {{server.lock}} file 
> when reading the state information in order to deal with stale data over NFS.
> However, the changes from ARTEMIS-2441 split the lock into several different 
> files which means that when the state information is read now the 
> {{server.lock}} file itself is not locked/unlocked which results in reading 
> stale data on the slave.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to