[
https://issues.apache.org/jira/browse/ARTEMIS-2604?focusedWorklogId=375690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-375690
]
ASF GitHub Bot logged work on ARTEMIS-2604:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jan/20 16:11
Start Date: 22/Jan/20 16:11
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2950: ARTEMIS-2604
Save Message decoding when unnecessary
URL: https://github.com/apache/activemq-artemis/pull/2950#discussion_r369654970
##########
File path:
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
##########
@@ -372,6 +372,79 @@ private synchronized void
forEachInternal(BiConsumer<SimpleString, PropertyValue
}
}
+ /**
+ * Performs a search among the valid key properties contained in {@code
buffer}, starting from {@code from}
+ * assuming it to be a valid encoded {@link TypedProperties} content.
+ *
+ * @throws IllegalStateException if any not-valid property is found while
searching the {@code key} property
+ */
+ public static boolean searchProperty(SimpleString key, ByteBuf buffer, int
startIndex) {
Review comment:
I have added a comment about this and the risk is to find a value that
matches the property we are searching for. The other reason is that we know how
many bytes to skip by using the decoded info and would help to reach quicker
what we need without comparing every single byte (including values)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 375690)
Time Spent: 2.5h (was: 2h 20m)
> Save Message decoding when unnecessary
> --------------------------------------
>
> Key: ARTEMIS-2604
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2604
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.12.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> There are few cases eg while loading journal or on common message routing
> where decoding a full message isn't necessary if certain properties aren't
> present.
> Performing a "brute-force" scan into the message not-yet-decoded raw contant
> would be welcome if compared to a full decoding that could be saved for later
> (or never).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
