[
https://issues.apache.org/jira/browse/ARTEMIS-2604?focusedWorklogId=379364&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-379364
]
ASF GitHub Bot logged work on ARTEMIS-2604:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/20 13:14
Start Date: 30/Jan/20 13:14
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2950: ARTEMIS-2604 Save
Message decoding when unnecessary
URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-580207415
@michaelandrepearce @clebertsuconic I've added some tests and this is ready
to get a full review.
After addressing all the review comments I'll squash the changes into one.
The CI is already in a good shape on this :+1:
There is just one thing that worries me about these optimizations and is
related to theirs fragility: how to ensure that future changes in the journal
loading process won't trigger by accident the encoding of the message? That was
a major cause of GC generation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 379364)
Time Spent: 5h 20m (was: 5h 10m)
> Save Message decoding when unnecessary
> --------------------------------------
>
> Key: ARTEMIS-2604
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2604
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.12.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> There are few cases eg while loading journal or on common message routing
> where decoding a full message isn't necessary if certain properties aren't
> present.
> Performing a "brute-force" scan into the message not-yet-decoded raw contant
> would be welcome if compared to a full decoding that could be saved for later
> (or never).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
