[
https://issues.apache.org/jira/browse/AMQNET-634?focusedWorklogId=381455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-381455
]
ASF GitHub Bot logged work on AMQNET-634:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/20 08:52
Start Date: 04/Feb/20 08:52
Worklog Time Spent: 10m
Work Description: michaelpearce-gain commented on pull request #53:
AMQNET-634: Use 4 as default msg priority
URL: https://github.com/apache/activemq-nms-amqp/pull/53#discussion_r374540801
##########
File path: test/Apache-NMS-AMQP-Test/NmsMessageProducerTest.cs
##########
@@ -77,7 +77,7 @@ public void TestGetDisableTimeStamp()
public void TestPriorityConfiguration()
{
IMessageProducer producer = session.CreateProducer(null);
- Assert.AreEqual(NMSConstants.defaultPriority, producer.Priority);
+ Assert.AreEqual(MsgPriority.BelowNormal, producer.Priority);
Review comment:
I would be explicit here with using int 4 (so we explicitly test the spec),
rather than relying on a constant from outside the test pack, which it could
change....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 381455)
Time Spent: 20m (was: 10m)
> Msg Priority is 5 by default instead of 4
> -----------------------------------------
>
> Key: AMQNET-634
> URL: https://issues.apache.org/jira/browse/AMQNET-634
> Project: ActiveMQ .Net
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 1.8.0
> Reporter: Krzysztof Porebski
> Priority: Major
> Fix For: AMQP-1.8.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There's a bug in the default priority that’s being used when not set, Int 5
> is being set, when in fact the default should be int 4 as per JMS spec.
> [https://docs.oracle.com/javaee/6/api/javax/jms/Message.html#DEFAULT_PRIORITY]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
