[
https://issues.apache.org/jira/browse/ARTEMIS-2604?focusedWorklogId=382267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-382267
]
ASF GitHub Bot logged work on ARTEMIS-2604:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/20 13:21
Start Date: 05/Feb/20 13:21
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #2950: ARTEMIS-2604 Save
Message decoding when unnecessary
URL: https://github.com/apache/activemq-artemis/pull/2950#issuecomment-581056951
@michaelandrepearce @wy96f I finally got some numbers about the loading of
journal:
this commit:
start: 19:28:08,193
end: 19:28:28,391
~20 seconds
2.11:
start: 12:12:22,651
end: 12:13:15,625
~ 53 seconds
It seems about twice as faster assuming a very fast disk :)
But, although it seems an improvement from the point of view of speed of the
algorithm of loading, in reality, it uses much less memory then before, hence
hitting much less full GCs.
In my tests, with. 2.5 GB if journal and a 4 GB broker, with this PR I can
lower the heap size until 3 GB getting decent performance while loading, while
with 2.11 i have to raise it to 6 GB to make the loading quick as this pr with
3 GB. And I still need to take care of Long boxing, probably in a follow up pr
;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 382267)
Time Spent: 7h 10m (was: 7h)
> Save Message decoding when unnecessary
> --------------------------------------
>
> Key: ARTEMIS-2604
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2604
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.12.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> There are few cases eg while loading journal or on common message routing
> where decoding a full message isn't necessary if certain properties aren't
> present.
> Performing a "brute-force" scan into the message not-yet-decoded raw contant
> would be welcome if compared to a full decoding that could be saved for later
> (or never).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
