[
https://issues.apache.org/jira/browse/ARTEMIS-2607?focusedWorklogId=384673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-384673
]
ASF GitHub Bot logged work on ARTEMIS-2607:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Feb/20 19:33
Start Date: 10/Feb/20 19:33
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on pull request #2974:
ARTEMIS-2607 interceptor returns false but processing continues
URL: https://github.com/apache/activemq-artemis/pull/2974#discussion_r377271568
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPSessionCallback.java
##########
@@ -507,8 +507,9 @@ private void serverSend(final ProtonServerReceiverContext
context,
final Receiver receiver,
final RoutingContext routingContext) throws
Exception {
message.setConnectionID(receiver.getSession().getConnection().getRemoteContainer());
- invokeIncoming((AMQPMessage) message, (ActiveMQProtonRemotingConnection)
transportConnection.getProtocolConnection());
- serverSession.send(transaction, message, directDeliver, false,
routingContext);
+ if (invokeIncoming((AMQPMessage) message,
(ActiveMQProtonRemotingConnection) transportConnection.getProtocolConnection())
== null) {
+ serverSession.send(transaction, message, directDeliver, false,
routingContext);
+ }
afterIO(new IOCallback() {
Review comment:
not really... afterIO will wait any pending IO to be executed, or to be
executed right away if there is no pending IO. in that sense if context is
empty, it will execute in thread.
That means that the confirmation (ack for the sends) will happen right away.
I'm not sure what is the expected semantic from the user on this case.
I would expect the disposition to be rejected on that case... and not
accepted. from this POV this is being accepted as if the message was actually
stored and delivered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 384673)
Time Spent: 40m (was: 0.5h)
> Interceptor returns false but processing continues
> --------------------------------------------------
>
> Key: ARTEMIS-2607
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2607
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.11.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When an interceptor for AMQP, STOMP, or MQTT returns {{false}} the broker
> continues to process the packet. This contradicts [the
> documentation|http://activemq.apache.org/components/artemis/documentation/latest/intercepting-operations.html]
> which states:
> bq. if {{false}} is returned, the process is aborted, no other interceptors
> will be called and the packet will not be processed further by the server.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)