[
https://issues.apache.org/jira/browse/ARTEMIS-2645?focusedWorklogId=398749&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398749
]
ASF GitHub Bot logged work on ARTEMIS-2645:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Mar/20 23:00
Start Date: 05/Mar/20 23:00
Worklog Time Spent: 10m
Work Description: jbertram commented on pull request #3003: ARTEMIS-2645
refactor CLI FQQN support
URL: https://github.com/apache/activemq-artemis/pull/3003
FQQN support for the CLI was implemented via ARTEMIS-1840 before general
FQQN support was added for producers via ARTEMIS-1867. The CLI's FQQN
functionality is slightly different from what is now generally available
and it can be confusing for users. By refactoring the CLI to use the
general FQQN support the code can be much simpler and consistent with
the expected behavior. Refactoring includes:
- Deprecating the use of "fqqn://". The CLI commands use JMS so using
"fqqn://" (instead of "queue://" or "topic://") makes the destination
type ambiguous which can yield unexpected message routing behavior.
Now "queue://" and "topic://" can be used with the normal FQQN syntax
(e.g. address::queue).
- Eliminating the use of the _AMQ_ROUTE_TO header when sending messags
to an FQQN. The _AMQ_ROUTE_TO header is an internal header used when
routing messages over a cluster bridge. Using it in the CLI for FQQN
support was a clever hack, but using the general FQQN support
eliminates complexity and makes behavior consistent between
standalone JMS clients using FQQN and the CLI.
- De-duplicating MessageSerializer initialization boilerplate.
- Removing limitation where using an FQQN with an anycast address
required the same name for the address and queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 398749)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor CLI FQQN support
> -------------------------
>
> Key: ARTEMIS-2645
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2645
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.11.0
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
