[
https://issues.apache.org/jira/browse/ARTEMIS-2658?focusedWorklogId=404163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-404163
]
ASF GitHub Bot logged work on ARTEMIS-2658:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Mar/20 18:15
Start Date: 16/Mar/20 18:15
Worklog Time Spent: 10m
Work Description: franz1981 commented on issue #3019: ARTEMIS-2658 AMQP
message read from page has wrong encode size
URL: https://github.com/apache/activemq-artemis/pull/3019#issuecomment-599679621
@clebertsuconic The perf issue is still present and more evident on master,
so this PR should be fine...I'll open a JIRA to investigate the performance
issue while loading the journal separately...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 404163)
Time Spent: 1h 20m (was: 1h 10m)
> AMQP message read from page has wrong encode size
> -------------------------------------------------
>
> Key: ARTEMIS-2658
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2658
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
> Affects Versions: 2.11.0
> Reporter: Francesco Nigro
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/ARTEMIS-2617 has introduced a change to
> save AMQPMessagePersisterV2::decode from re-creating
> AMQPMessage::extraProperties, but this has introduced a new way to adjust the
> existing AMQPMessage::extraProperties's TypedProperties::size while decoding
> the rest of the buffer.
> In the original implementation, the existing AMQPMessage::extraProperties
> created by AMQPMessagePersister::decode was completely overwritten.
> Page::read can use an offset to search for a specific message in a page and
> PageSubscriptionImpl is using PagedMessageImpl::getEncodeSize to compute this
> offset: after a successfull Page::read, AMQPMessagePersisterV2::decode can
> corrupt the extra properties encode size, making the next message unreachable.
> This can be solved by preserving the original semantic ie overwriting the
> existing AMQPMessage::extraProperties in order to fix the encode size.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
