[
https://issues.apache.org/jira/browse/ARTEMIS-2669?focusedWorklogId=407233&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407233
]
ASF GitHub Bot logged work on ARTEMIS-2669:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 20:51
Start Date: 20/Mar/20 20:51
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3036: ARTEMIS-2669
not durable AMQP messages cannot became durable on depaging
URL: https://github.com/apache/activemq-artemis/pull/3036#discussion_r395884092
##########
File path:
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java
##########
@@ -837,16 +837,26 @@ protected synchronized void
lazyScanAfterReloadPersistence() {
messageDataScanned = MessageDataScanningStatus.SCANNED.code;
modified = false;
+ makeDurable();
+ }
+
+ private void makeDurable() {
+ assert messageDataScanned == MessageDataScanningStatus.SCANNED.code;
// Message state should reflect that is came from persistent storage
which
// can happen when moved to a durable location. We must re-encode here
to
// avoid a subsequent redelivery from suddenly appearing with a durable
header
// tag when the initial delivery did not.
if (!isDurable()) {
Review comment:
The label can be removed: now the PR is removing the legacy code and
improving the test coverage to spot any regression on this behaviour :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 407233)
Time Spent: 2.5h (was: 2h 20m)
> ARTEMIS-2669 not durable AMQP messages cannot became durable on depaging
> ------------------------------------------------------------------------
>
> Key: ARTEMIS-2669
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2669
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP, Broker
> Affects Versions: 2.11.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently depaging AMQP not durable messages turn them into durable ones and
> reencoded again: this shouldn't really happen, hence the mentioned code
> should be deleted if it proves to not have side-effects.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
