[
https://issues.apache.org/jira/browse/ARTEMIS-2608?focusedWorklogId=407914&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407914
]
ASF GitHub Bot logged work on ARTEMIS-2608:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/20 14:23
Start Date: 23/Mar/20 14:23
Worklog Time Spent: 10m
Work Description: fvaleri commented on issue #2954: ARTEMIS-2608 Fix
ClassCastException on binary properties retrieval
URL: https://github.com/apache/activemq-artemis/pull/2954#issuecomment-602618829
@gemmellr is right. The problem is in the `AmqpCoreConverter.setProperty`
method which convert proton-j's Binary to String instead of byte[]:
```java
...
} else if (value instanceof Binary) {
msg.setStringProperty(key, value.toString());
```
Please review my last commit which fixes the issue, adds a converter test
and a bit of refactoring to have separate classes for CoreOpenWireConverter and
OpenWireCoreConverter (much like in the AMQP protocol module).
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 407914)
Time Spent: 3h (was: 2h 50m)
> ClassCastException when consuming a message using OpenWire
> ----------------------------------------------------------
>
> Key: ARTEMIS-2608
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2608
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: OpenWire
> Affects Versions: 2.11.0
> Reporter: Federico Valeri
> Priority: Major
> Attachments: cce-reproducer.zip
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This issue seems to be related to the conversion of binary properties.
> Quick workaround: clear message properties in the AMQP producer.
> Reproducer (attached):
> 1. Send a message to the broker using OpenWire client
> 2. Consume that message using AMQP client
> 3. Send that message back to the broker using AMQP client
> Result: message could not be consumed by the OpenWire consumer.
> {code:java}
> 2020-01-23 12:52:44,095 WARN [org.apache.activemq.artemis.core.server] Error
> during message dispatch: java.lang.ClassCastException:
> org.apache.activemq.artemis.api.core.SimpleString cannot be cast to [B
> at
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.toAMQMessage(OpenWireMessageConverter.java:629)
> [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireMessageConverter.createMessageDispatch(OpenWireMessageConverter.java:501)
> [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.openwire.amq.AMQConsumer.handleDeliver(AMQConsumer.java:258)
> [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.protocol.openwire.amq.AMQSession.sendMessage(AMQSession.java:312)
> [artemis-openwire-protocol-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.deliverStandardMessage(ServerConsumerImpl.java:1161)
> [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.ServerConsumerImpl.proceedDeliver(ServerConsumerImpl.java:504)
> [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.proceedDeliver(QueueImpl.java:3510)
> [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2856)
> [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:122)
> [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3848)
> [artemis-server-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
> [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
> [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
> [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> [rt.jar:1.8.0_232]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> [rt.jar:1.8.0_232]
> at
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
> [artemis-commons-2.11.0-SNAPSHOT.jar:2.11.0-SNAPSHOT]
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
