[
https://issues.apache.org/jira/browse/ARTEMIS-1975?focusedWorklogId=409293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409293
]
ASF GitHub Bot logged work on ARTEMIS-1975:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/20 03:01
Start Date: 25/Mar/20 03:01
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #3048: ARTEMIS-1975
Fixing LargeMessage encoding for replication
URL: https://github.com/apache/activemq-artemis/pull/3048#issuecomment-603613295
today I have sent two commits directly into master, as I thought they were
obvious change that didn't require peer review.
in the process I broke
org.apache.activemq.artemis.tests.integration.amqp.largemessages.AmqpReplicatedLargeMessageTest
this is fixing AmqpReplicatedLargeMessageTest
Instead of using a Thread local for the cache of the saved buffer, I'm
storing the record on the Message.
However for replication, this may be broken due to multi-threading.
This is fixing that by adding reference counting.
I did some manual testing to make sure there are no leaks. I couldn't find a
way to add a permanent test without being invasive in performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 409293)
Time Spent: 2.5h (was: 2h 20m)
> Real LargeMessage support for AMQP
> ----------------------------------
>
> Key: ARTEMIS-1975
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1975
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.6.2, 2.11.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.12.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This task in between a bug and an improvement.
>
> Currently LargeMessages in AMQP are converted to Core.
> We should at least not require a conversion.. keep large messages in AMQP
> without conversions.
>
> Optionally it would be nice to stream in AMQP as well. but if we can at least
> prevent conversions it's already a big win!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
