[ 
https://issues.apache.org/jira/browse/ARTEMIS-2680?focusedWorklogId=409484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409484
 ]

ASF GitHub Bot logged work on ARTEMIS-2680:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Mar/20 12:58
            Start Date: 25/Mar/20 12:58
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on pull request #3047: ARTEMIS-2680 
use q name for addr if none specified via config
URL: https://github.com/apache/activemq-artemis/pull/3047#discussion_r397832801
 
 

 ##########
 File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/server/ConfigurationTest.java
 ##########
 @@ -47,6 +49,22 @@ public void testStartWithDuplicateQueues() throws Exception 
{
       }
    }
 
+   @Test
+   public void testQueueWithoutAddressName() throws Exception {
+      final SimpleString QUEUE_NAME = RandomUtil.randomSimpleString();
+      ActiveMQServer server = createServer(false, createDefaultInVMConfig());
+      try {
+         server.getConfiguration().addQueueConfiguration(new 
CoreQueueConfiguration().setName(QUEUE_NAME.toString()));
 
 Review comment:
   I don't think this would be possible via the XML. It's only possible by 
using the `CoreQueueConfiguration` object directly.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 409484)
    Time Spent: 40m  (was: 0.5h)

> Use queue name for address if none specified via configuration
> --------------------------------------------------------------
>
>                 Key: ARTEMIS-2680
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2680
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> If 
> {{org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl#createQueue()}}
>  is invoked with an effectively {{null}} address name then the queue name 
> will be used for the address. This is not true of queues created via 
> {{org.apache.activemq.artemis.core.config.CoreQueueConfiguration}}, but it 
> should be.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to