[ 
https://issues.apache.org/jira/browse/ARTEMIS-2681?focusedWorklogId=409811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409811
 ]

ASF GitHub Bot logged work on ARTEMIS-2681:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Mar/20 20:43
            Start Date: 25/Mar/20 20:43
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #3049: 
ARTEMIS-2681 timestamp not set on notif msgs
URL: https://github.com/apache/activemq-artemis/pull/3049#discussion_r398156316
 
 

 ##########
 File path: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/SecurityNotificationTest.java
 ##########
 @@ -155,6 +163,8 @@ public void testCONSUMER_CREATED() throws Exception {
       Assert.assertEquals("guest", 
notifications[0].getObjectProperty(ManagementHelper.HDR_VALIDATED_USER).toString());
       Assert.assertEquals(address.toString(), 
notifications[0].getObjectProperty(ManagementHelper.HDR_ADDRESS).toString());
       Assert.assertEquals(SimpleString.toSimpleString("unavailable"), 
notifications[0].getSimpleStringProperty(ManagementHelper.HDR_CERT_SUBJECT_DN));
+      Assert.assertTrue(notifications[0].getTimestamp() >= start);
+      Assert.assertTrue((Long) 
notifications[0].getObjectProperty(ManagementHelper.HDR_NOTIFICATION_TIMESTAMP) 
>= start);
 
 Review comment:
   shouldn't we assert for == .getTimestamp()? given the way it's implemented?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 409811)
    Time Spent: 20m  (was: 10m)

> Timestamp not set on notification messages
> ------------------------------------------
>
>                 Key: ARTEMIS-2681
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2681
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to