[ 
https://issues.apache.org/jira/browse/ARTEMIS-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084395#comment-17084395
 ] 

Clebert Suconic commented on ARTEMIS-2712:
------------------------------------------

testing wise I'm modifying a MockTest Tim Bish added to validate 
clearLargeMessage has been called. (ProtonServerReceiverContextTest)

 

I usually dislike Mock tests as it forces you to validate the code and not 
actual semantics, but this would be good enough.

the PR is here: [https://github.com/apache/activemq-artemis/pull/3087]

When I misunderstood what you meant by the connection drops I actually found an 
actual issue with connection drops.. you killed two bugs with a single shot! :) 
and I fixed them both on the same PR.

> updated large message handling not accounted for in aborted message cleanup
> ---------------------------------------------------------------------------
>
>                 Key: ARTEMIS-2712
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2712
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.12.0
>            Reporter: Robbie Gemmell
>            Priority: Blocker
>             Fix For: 2.12.0
>
>         Attachments: helloworld.py
>
>
> ARTEMIS-1975 updated the message handling for 'larger' AMQP messages, but in 
> doing so introduces additional behaviours while handling such messages. These 
> dont appear to have been similarly catered for during aborted message cleanup 
> (irony: those being more likely for this to be needed). As such it currently 
> looks like message corruption could occur if a subsequent message arrived 
> after an abort.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to