[
https://issues.apache.org/jira/browse/ARTEMIS-2676?focusedWorklogId=423194&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-423194
]
ASF GitHub Bot logged work on ARTEMIS-2676:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/20 02:20
Start Date: 16/Apr/20 02:20
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on issue #3044: ARTEMIS-2676
PageCursorProviderImpl::cleanup can save decoding pages without large messages
URL: https://github.com/apache/activemq-artemis/pull/3044#issuecomment-614375921
I was thinking about... I need this as part of this release.
the change you made here wouldn't break the compatibility if released now...
but it would break if released later.
up till now we didn't have any other type of large messages...
so if we release now, the byte(2) on PagedMessages would make a lot of
sense...
if we released later, we would have to deal with previous versions where you
may have AMQPLargeMessage with byte(1), while this PR is expecting byte(2).
so, I am merging this now.
Besides I have a full pass on this PR as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 423194)
Time Spent: 5h 40m (was: 5.5h)
> PageCursorProviderImpl::cleanup can save decoding pages without large messages
> ------------------------------------------------------------------------------
>
> Key: ARTEMIS-2676
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2676
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.11.0
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
> PageCurosrProviderImpl::cleanup is calling
> PageCurosrProviderImpl::finishCleanup that's fully reading pages (when not
> present in the PageCache), just to trigger large messages delete.
> The decoding phase could be skipped and possibly the page read as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
