[
https://issues.apache.org/jira/browse/AMQNET-565?focusedWorklogId=424916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424916
]
ASF GitHub Bot logged work on AMQNET-565:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Apr/20 16:18
Start Date: 18/Apr/20 16:18
Worklog Time Spent: 10m
Work Description: lrushl commented on issue #9: [AMQNET-565] - .net
standard conversion, project reorganization
URL:
https://github.com/apache/activemq-nms-openwire/pull/9#issuecomment-615897504
Let me share my update on this pr.
- 27 unit test are ignored (26 tests are DTC tests that currently not
supported on .net core) + 1 tests that most likely was never passing
(TestSetEmptyPropertyName)). Furthermore, `TestSetEmptyPropertyName` test fails
on all target frameworks.
- 3 unit tests fail on all frameworks all the time.
It looks like the `TestTmpQueueWorksUnderLoad` test was never passing. This
test fails on the following
[line](https://github.com/apache/activemq-nms-openwire/blob/0ccbe7e8c68d41709375fe6bcbff75dbc8e917fd/test/TempDestinationTest.cs#L197)
in test and the following [line in
lib](https://github.com/apache/activemq-nms-openwire/blob/0ccbe7e8c68d41709375fe6bcbff75dbc8e917fd/src/Commands/MessageId.cs#L175).
The reason for failure is that `MessageId.BrokerSequenceId` of the original
message is not updated after a message is produced but the corresponding
message on the consumer side does have the `MessageId.BrokerSequenceId`
property value set. As far as I understand this value was never supposed to be
updated on the producer side.
- Regarding the `Thread.Abort` issue mentioned above, I assume that in
current implementation we can just enclose it with the `#if` preprocessor
directive in order to avoid the `PlatformNotSupportedException` exception.
Please share your thoughts on this issue.
- The other thing that is not related to this particular PR but none the
less worth to be mentioned is that OpenWire protocol on the server has been
already updated to version 12. The java client counterpart is also updated to
version 12. The other interesting thing is that .net client has some
autogenerated pieces of code that are being autogenerated by the
[activemq-nms-openwire-generator](https://github.com/apache/activemq-nms-openwire-generator).
I'd like to suggest to move issues with unit tests and protocol upgrade
(except Thread.Abort) out of the scope of this PR and create separate JIRA
tickets for them.
Looking forward to your feedback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424916)
Time Spent: 11h 50m (was: 11h 40m)
> Dotnet core port
> -----------------
>
> Key: AMQNET-565
> URL: https://issues.apache.org/jira/browse/AMQNET-565
> Project: ActiveMQ .Net
> Issue Type: New Feature
> Components: ActiveMQ
> Reporter: Wojtek Kulma
> Priority: Major
> Time Spent: 11h 50m
> Remaining Estimate: 0h
>
> Apache.NMS.ActiveMQ should be ported for dotnet core.
> For now the following error is rises:
> D:\RiderProjects\syncro [master ≡ +1 ~1 -1 !]> dotnet add package
> Apache.NMS.ActiveMQ
> Microsoft (R) Build Engine version 15.1.1012.6693
> Copyright (C) Microsoft Corporation. All rights reserved.
> Writing C:\Users\wkulma\AppData\Local\Temp\tmp9A2E.tmp
> info : Adding PackageReference for package 'Apache.NMS.ActiveMQ' into project
> 'D:\RiderProjects\syncro\syncro.fsproj'.
> log : Restoring packages for D:\RiderProjects\syncro\syncro.fsproj...
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json
> info : CACHE https://api.nuget.org/v3-flatcontainer/fsharp.core/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.core/4.1.17/fsharp.core.4.1.17.nupkg
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/index.json
> info : CACHE
> https://api.nuget.org/v3-flatcontainer/fsharp.net.sdk/1.0.5/fsharp.net.sdk.1.0.5.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/index.json 611ms
> info : GET
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> info : OK
> https://api.nuget.org/v3-flatcontainer/apache.nms.activemq/1.7.2/apache.nms.activemq.1.7.2.nupkg
> 481ms
> error: Package Apache.NMS.ActiveMQ 1.7.2 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS.ActiveMQ 1.7.2 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: Package Apache.NMS 1.7.1 is not compatible with netcoreapp1.1
> (.NETCoreApp,Version=v1.1). Package Apache.NMS 1.7.1 supports:
> error: - net20 (.NETFramework,Version=v2.0)
> error: - net20-cf (.NETFramework,Version=v2.0,Profile=CompactFramework)
> error: - net35 (.NETFramework,Version=v3.5)
> error: - net40 (.NETFramework,Version=v4.0)
> error: One or more packages are incompatible with .NETCoreApp,Version=v1.1.
> error: Package 'Apache.NMS.ActiveMQ' is incompatible with 'all' frameworks in
> project 'D:\RiderProjects\syncro\syncro.fsproj'.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
