[
https://issues.apache.org/jira/browse/ARTEMIS-2717?focusedWorklogId=425259&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-425259
]
ASF GitHub Bot logged work on ARTEMIS-2717:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/20 09:23
Start Date: 20/Apr/20 09:23
Worklog Time Spent: 10m
Work Description: franz1981 commented on a change in pull request #3094:
URL: https://github.com/apache/activemq-artemis/pull/3094#discussion_r411226674
##########
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ClusterControl.java
##########
@@ -64,6 +62,10 @@ public ClusterControl(ClientSessionFactoryInternal
sessionFactory, ActiveMQServe
this.clusterPassword = server.getConfiguration().getClusterPassword();
}
+ public Optional<Channel> getClusterChannel() {
Review comment:
@michaelandrepearce @brusdev Not proud to have "exposed" the lower level
`Channel` here, but it seems the simplest way to move away he many `Quorum*`
deps away from here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 425259)
Time Spent: 1h 20m (was: 1h 10m)
> Isolate the current Quorum Vote implementation
> ----------------------------------------------
>
> Key: ARTEMIS-2717
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2717
> Project: ActiveMQ Artemis
> Issue Type: Sub-task
> Components: Broker
> Reporter: Francesco Nigro
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As a first step to design and implement the new Quorum Vote API is necessary
> to isolate the functionalities of the current one, to better understand what
> we're going to replace/change.
> From an high level perspective it means understanding the exact
> functionalities it's providing to support shared nothing HA, while from an
> implementation perspective it means to pack the current usage of the classes
> implementing it (eg QuorumManager) into higher abstraction level domain
> methods.
> This effort won't change the way the current Quorum Vote algorithm works
> hence it would be nice to make it part of the Artemis code before delivering
> the new pluggable implementation too.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
