[
https://issues.apache.org/jira/browse/ARTEMIS-2372?focusedWorklogId=428528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-428528
]
ASF GitHub Bot logged work on ARTEMIS-2372:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/20 11:42
Start Date: 29/Apr/20 11:42
Worklog Time Spent: 10m
Work Description: gemmellr commented on pull request #2695:
URL: https://github.com/apache/activemq-artemis/pull/2695#issuecomment-621148356
I dont think this should have been added before
https://issues.apache.org/jira/browse/ARTEMIS-2740 is addressed. I know that
JIRA is new, but I see the issue was raised in comments here when this PR was
raised last year, and the PR closed, but now reopened/updated and added anyway
- with the tests still using annotations that are reserved. It seems unwise to
add a new functionality that relies on/encourages this behaviour, given fixing
that would then necessarily break any uses of this new functionality.
It also seems that now any use of filters where the key value isnt found in
application properties is going to decode every annotation now. Unlikely to be
great for performance, and especially not nice for folks who aren't even
looking to filter on any annotations, which is likely to be most values for
most people, and certainly every existing user up to this point given it wasn't
even possible before.
The filter extensions spec in the AMQP TC
(https://www.oasis-open.org/committees/document.php?document_id=66227) is
currently proposing using "m.<annotation-key>" as a means of requesting
filtering on the message-annotations map within an SQL based filter string. It
might be worth aligning to that, as it would at least allow avoiding decoding
annotations when folks have not asked for them to be filtered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 428528)
Time Spent: 3h 10m (was: 3h)
> Support Filtering on Message Annotations
> ----------------------------------------
>
> Key: ARTEMIS-2372
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2372
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.9.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
