[
https://issues.apache.org/jira/browse/ARTEMIS-2648?focusedWorklogId=429526&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429526
]
ASF GitHub Bot logged work on ARTEMIS-2648:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/May/20 15:37
Start Date: 01/May/20 15:37
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on a change in pull request
#3107:
URL: https://github.com/apache/activemq-artemis/pull/3107#discussion_r418596091
##########
File path:
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireConnection.java
##########
@@ -287,6 +288,9 @@ public void bufferReceived(Object connectionID,
ActiveMQBuffer buffer) {
if (logger.isTraceEnabled()) {
traceBufferReceived(connectionID, command);
}
+ if (AuditLogger.isAnyLoggingEnabled()) {
+ AuditLogger.setRemoteAddress(getRemoteAddress());
Review comment:
I mean.. why don't you inject the data you need on the operation
context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 429526)
Time Spent: 1h 40m (was: 1.5h)
> Improve the Audit logging capabilities
> --------------------------------------
>
> Key: ARTEMIS-2648
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2648
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This will improve the current audit logging feature. currently there are 2
> loggers which are very verbose so this will add a 3rd which focus mainly
> around access to resources that a console user or a jmx client may use. Also
> currently no success/failure is logged only entry points in methods, this new
> logger will log success or failure.
> Here is a list of the improvements:
> * New Resource logger added
> ** This will log more resource related access from JMX/console mainly around
> creation of resources and access to these resource
> ** It will be enabled independently of the other loggers
> * Message audit log will be changed to be configurable independently not
> with base audit log, and the new resource logger will also be configurable
> independently.
> * Add the ability to capture the remote address of the calling client
> whether it be through JMX/console or a normal Netty connection
> * Add the ability to capture authentication success or failure from the
> console
>
> * Add the ability to log failures to JMX mbeans in the authentication
> process.
>
> Also tidy up the current logger codes.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
