[ 
https://issues.apache.org/jira/browse/ARTEMIS-2445?focusedWorklogId=430195&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-430195
 ]

ASF GitHub Bot logged work on ARTEMIS-2445:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/May/20 13:48
            Start Date: 04/May/20 13:48
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on a change in pull request 
#3113:
URL: https://github.com/apache/activemq-artemis/pull/3113#discussion_r419449643



##########
File path: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/Message.java
##########
@@ -81,7 +81,7 @@
    // We use properties to establish routing context on clustering.
    // However if the client resends the message after receiving, it needs to 
be removed, so we mark these internal
    Predicate<SimpleString> INTERNAL_PROPERTY_NAMES_PREDICATE =
-      name -> (name.startsWith(Message.HDR_ROUTE_TO_IDS) && 
!name.equals(Message.HDR_ROUTE_TO_IDS)) ||

Review comment:
       HDR_ROUTE_TO_IDS is used to transfer messages to a different cluster.
   
   Perhaps you had messages moving to a different cluster and thought they were 
lost.
   
   Without a proper test, this PR cannot be merged. If you have a real case you 
need to prove it at least.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 430195)
    Time Spent: 20m  (was: 10m)

> Large message lost for divert
> -----------------------------
>
>                 Key: ARTEMIS-2445
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2445
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.9.0
>            Reporter: Bhavesh Kharwa
>            Priority: Major
>         Attachments: server1-master.xml, server2-master.xml
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
>  
> I have following queue setup in cluster:
>  * server1 running on 61616
>  * server2 running on 61617
> I start two consumer with two different available master server
>  {noformat}
> java -jar AmqJmsConsume.jar -duration 5 -queue IT-InputQueue -stats -log
> /tmp/artemis/4 -verify -commitdelay 300 -url 'tcp://localhost:61616'
> java -jar AmqJmsConsume.jar -duration 5 -queue IT-InputQueue -stats -log
> /tmp/artemis/4 -verify -commitdelay 300 -url 'tcp://localhost:61617' 
> {noformat}
> and run producer to server1 as below 
>  {noformat}
> java -jar AmqJmsProducer.jar -topic RFTopic -stats -log /tmp/artemis/4 -id
> -count 500 -n 500 -ttl 3600000 -url 'tcp://localhost:61616' -outliers 100
> -outliersize 500k
> {noformat}
> both consumer gets few message but after below exception server1 clears queue 
> with almost 50% of messages but rest of messages are stuck with 
> internal.sf.cluster queue and not received by any consumer.
> {noformat}
> java.lang.IllegalStateException: no queueIDs defined
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionBridge.beforeForward(ClusterConnectionBridge.java:182)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl.handle(BridgeImpl.java:653)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.handle(QueueImpl.java:3346)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2606)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:117)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3613)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [rt.jar:1.8.0_211]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [rt.jar:1.8.0_211]
>     at 
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
>  [artemis-commons-2.9.0.jar:2.9.0]
> 2019-07-29 10:21:38,503 WARN  
> [org.apache.activemq.artemis.core.server.impl.QueueImpl] null: 
> java.util.NoSuchElementException
>     at 
> org.apache.activemq.artemis.utils.collections.PriorityLinkedListImpl$PriorityLinkedListIterator.repeat(PriorityLinkedListImpl.java:172)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.deliver(QueueImpl.java:2627)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl.access$2300(QueueImpl.java:117)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:3613)
>  [artemis-server-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:42)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.utils.actors.OrderedExecutor.doTask(OrderedExecutor.java:31)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> org.apache.activemq.artemis.utils.actors.ProcessorBase.executePendingTasks(ProcessorBase.java:66)
>  [artemis-commons-2.9.0.jar:2.9.0]
>     at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  [rt.jar:1.8.0_211]
>     at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  [rt.jar:1.8.0_211]
>     at 
> org.apache.activemq.artemis.utils.ActiveMQThreadFactory$1.run(ActiveMQThreadFactory.java:118)
>  [artemis-commons-2.9.0.jar:2.9.0]
> {noformat}
> Also please find attached server1-master and server2-master broker file.
> For reproducibility : Download client code from github url: 
> github.com/erik-wramner/JmsTools.git.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to