[ 
https://issues.apache.org/jira/browse/ARTEMIS-2751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17100113#comment-17100113
 ] 

Robbie Gemmell commented on ARTEMIS-2751:
-----------------------------------------

At least historically, those methods may (or may not) have manipulated the 
brokers in-memory representation but not the encoded data received from the 
sender that was then sent to consumers. At least unless the message was 
separately explicitly re-encoded as a sort of 'yes, I totally want to violate 
the spec' decision signal. The harm is that you are changing something that is 
expressly meant to be immutable [1], and so may cause you problems should 
anything be checking or impacted by that later.

[1] 
[http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-messaging-v1.0-os.html#section-message-format]

> Call to AMQPMessage.setValidatedUserID does nothing
> ---------------------------------------------------
>
>                 Key: ARTEMIS-2751
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2751
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: AMQP
>    Affects Versions: 2.12.0
>            Reporter: Viktor Kolomeyko
>            Priority: Major
>
> Method {{setValidatedUserID}} is not overridden for {{AMQPMessage}} class - 
> therefore it calls parent implementation which does nothing.
> On the other hand: 
> {{org.apache.activemq.artemis.core.message.impl.CoreMessage#setValidatedUserID}}
>  does the right thing and correctly retains validated user information as 
> supplied by 
> {{org.apache.activemq.artemis.core.server.impl.ServerSessionImpl#doSend}}
>  This deficiency prevents from reading 
> {{org.apache.activemq.artemis.api.core.Message#HDR_VALIDATED_USER}} attribute 
> when it is received via AMQP protocol. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to