[
https://issues.apache.org/jira/browse/ARTEMIS-2739?focusedWorklogId=431779&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431779
]
ASF GitHub Bot logged work on ARTEMIS-2739:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/20 15:02
Start Date: 07/May/20 15:02
Worklog Time Spent: 10m
Work Description: brusdev commented on a change in pull request #3118:
URL: https://github.com/apache/activemq-artemis/pull/3118#discussion_r421573611
##########
File path:
artemis-boot/src/main/java/org/apache/activemq/artemis/boot/Artemis.java
##########
@@ -46,7 +46,11 @@ public static void main(String[] args) throws Throwable {
String instance = System.getProperty("artemis.instance");
File fileInstance = instance != null ? new File(instance) : null;
- execute(fileHome, fileInstance, args);
+
+ Object result = execute(fileHome, fileInstance, args);
+ if (result instanceof Exception) {
Review comment:
The exception messages are already printed in the execute method.
> try {
> return internalExecute(artemisHome, artemisInstance, args,
context);
> } catch (ConfigurationException configException) {
> System.err.println(configException.getMessage());
> System.out.println();
> System.out.println("Configuration should be specified as
'scheme:location'. Default configuration is
'xml:${ARTEMIS_INSTANCE}/etc/bootstrap.xml'");
> return configException;
> } catch (CLIException cliException) {
> System.err.println(cliException.getMessage());
> return cliException;
> } catch (NullPointerException e) {
> // Yeah.. I really meant System.err..
> // this is the CLI and System.out and System.err are common
places for interacting with the user
> // this is a programming error that must be visualized and
corrected
> e.printStackTrace();
> return e;
> } catch (RuntimeException | InvalidOptionsError re) {
> System.err.println(re.getMessage());
> System.out.println();
>
> Cli<Action> parser = builder(null).build();
>
> parser.parse("help").execute(context);
> return re;
> }
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431779)
Time Spent: 50m (was: 40m)
> Artemis health check tool
> -------------------------
>
> Key: ARTEMIS-2739
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2739
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Domenico Bruscino
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Artemis health check tool determines the broker's health state, testing
> whether an aspect of the broker is operating as expected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
