[
https://issues.apache.org/jira/browse/ARTEMIS-2766?focusedWorklogId=434000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-434000
]
ASF GitHub Bot logged work on ARTEMIS-2766:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/May/20 05:00
Start Date: 16/May/20 05:00
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #3138:
URL: https://github.com/apache/activemq-artemis/pull/3138#issuecomment-629589019
Bud sorry that I have been able to read this just now from my phone: the
IdentityHashMap (on MSG_BODY_TYPES) I have used was meant to be used to search
just MessageAnnotations: you should remove any (potentially) terminal section
before the one you're searching to build the right one for your use case.
In the current state of this PR if you hit a MessageAnnotations while
searching for Data you will return with a false from the research of the
Symbol, that's not correct.
I suggest, for simplicity, to build your own static final Identity hashmap
with the correct terminal symbols for the data section (including the data
section) and just expose an "anyData" search method instead of a more generic
one. Another solution can be to remove the map and use some of the loops used
by Robbie or Tim to do similar things, in order to exit when some terminal
symbol beyond what you're expecting to find is being found.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 434000)
Time Spent: 50m (was: 40m)
> Avoid parsing application properties for duplicate detection
> ------------------------------------------------------------
>
> Key: ARTEMIS-2766
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2766
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.12.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.13.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> since ARTEMIS-2294 we now parse the application properties in AMQP looking
> for a similar core property on duplicate properties.
> We always intended for application properties as much as possible to not be
> parsed and just walk through the server.
> This seems a small gain, but if you are using very complex headers, this
> could be a huge gain depending on the usecase.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
