[ 
https://issues.apache.org/jira/browse/ARTEMIS-2776?focusedWorklogId=436277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436277
 ]

ASF GitHub Bot logged work on ARTEMIS-2776:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/May/20 23:31
            Start Date: 21/May/20 23:31
    Worklog Time Spent: 10m 
      Work Description: zekeoptimo commented on pull request #3146:
URL: https://github.com/apache/activemq-artemis/pull/3146#issuecomment-632397245


   This solves a couple of problems: 
   
   1) The ANONYMOUS_LOGIN environment variable was not being used, and in 
testing I found that it would default to allow anonymous logging no matter what 
(due to the --silent command being forced to make a choice)
   
   2) I believe this will make configuration easier, particular in an 
environment where usernames and/or passwords are kept as secrets. Allowing the 
ability to specify other parameters via EXTRA_ARGS allows specifying usernames 
and passwords separately from other configuration.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 436277)
    Time Spent: 20m  (was: 10m)

> Dockerfile Improvements
> -----------------------
>
>                 Key: ARTEMIS-2776
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2776
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>         Environment: Windows 10 running scripts in WSL
>            Reporter: Zeke Rogers
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The current Dockerfiles for Ubuntu and CentOS contain an environment variable 
> ANONYMOUS_LOGIN that is not actually being used, resulting in anonymous 
> logins always being allowed.
> In addition, the options "--http-host 0.0.0.0 --relax-jolokia" are included 
> by default, and overriding them would also require putting the username and 
> password in the  entire CREATE_ARGUMENTS environment variable, making the 
> previous ARTEMIS_USER and ARTEMIS_PASSWORD variables moot.
> This could be made easier to add extra options without having to re-specify 
> the username and the password. This is especially true in environments where 
> a secrets file may be used for usernames/passwords (such as Kubernetes) but 
> the rest of the args can be in plain text. In this scenario, having the 
> username and password as separate envrionment variables from the other 
> arguments is very beneficial.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to