[
https://issues.apache.org/jira/browse/ARTEMIS-2614?focusedWorklogId=436893&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-436893
]
ASF GitHub Bot logged work on ARTEMIS-2614:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/May/20 14:05
Start Date: 24/May/20 14:05
Worklog Time Spent: 10m
Work Description: Havret edited a comment on pull request #3124:
URL: https://github.com/apache/activemq-artemis/pull/3124#issuecomment-633233631
@jbertram, @gemmellr
So after all it wasn't too productive discussion. I debugged the code, and
apparently methods `createSharedDurableQueue` and `createUnsharedDurableQueue`
don't explicitly create durable queues. :) The queues are durable by default if
it's not specified otherwise. So if I drop "setDurable" bits, FQQN queues will
be created as durable which makes sense, and doesn't break anything.
However, there are still some things that need to be cleared up regarding my
first question.
> There is a problem with the RoutingType mismatch. Previously it didn't
matter what RoutingType receiver tries to attach to, as the implementation
assumed pre-existence of the queue. Now the routing type matters, as we need to
create a properly configured queue if it doesn't exist. That's why
testQueueConsumerReceiveTopicUsingFQQN test fails currently. To make it pass I
would need to subscribe to a topic instead of a queue. I'm not sure but is this
a breaking change or not?
STOMP implementation that @jbertram recently added
https://github.com/apache/activemq-artemis/pull/3018 seems to silently ignore
passed routing type when the mismatch occurs. Should I do the same here? It
would be the safest way I guess, but what do you guys think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 436893)
Time Spent: 1h 20m (was: 1h 10m)
> Create queues for AMQP clients based on FQQN
> --------------------------------------------
>
> Key: ARTEMIS-2614
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2614
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: AMQP
> Reporter: Krzysztof Porębski
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> As a follow up to the discussion on the mailing list I would like to suggest
> a new feature regarding FQQN implementation for AMQP protocol - creating
> queues.
> Currently there is no way of attaching to a queue using FQQN if the queue is
> not configured upfront. It should be changed so it would be possible to
> create queue via FQQN and a subset of the following capabilities:
> - shared
> - topic
> - queue
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
