[ 
https://issues.apache.org/jira/browse/ARTEMIS-2614?focusedWorklogId=437381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-437381
 ]

ASF GitHub Bot logged work on ARTEMIS-2614:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/May/20 03:42
            Start Date: 27/May/20 03:42
    Worklog Time Spent: 10m 
      Work Description: Havret edited a comment on pull request #3124:
URL: https://github.com/apache/activemq-artemis/pull/3124#issuecomment-634267603


   I'm not sure if mixing JMS concepts into this is the best idea. Determining 
whether a queue is durable/non-durable or shared/non-shared based on routing 
type seems to me pretty non-intuitive.
   
   Moreover, the way that JMS differentiate `createDurableconsumer(Topic)` and 
`createConsumer(Topic)` is based on `TerminusDurability` and 
`TerminusExpiryPolicy`. As @gemmellr  tried to explain to me throughout the big 
chunk of this thread, this property cannot be used to determine whether a queue 
is durable or not. 
   
   In the ideal world, I would just use `TerminusDurability` and `shared` 
capability. Having these two properties with FQQN, would make it possible to 
fully leverage Artemis Address Model in a dead-simple way:
   
   | Address   | Queue  | Routing Type  | Durable | Shared|amqp address  | 
capabilities  | durable |
   |---|---|---|---|---|---|---|---|
   | a1  | q1  | Multicast  | true  | true  | a1::q1 | shared, topic | 2|
   | a1  | q1  | Anycast| true  | true  | a1::q1 | shared, queue | 2|
   | a1  | q1  | Multicast  | true  | false| a1::q1 | topic | 2|
   | a1  | q1  | Anycast| true  | false  | a1::q1 | queue | 2|
   | a1  | q1  | Multicast  | false | true  | a1::q1 | shared, topic | 0 |
   | a1  | q1  | Anycast| true  | false  | a1::q1 | shared, queue | 0 |
   | a1  | q1  | Multicast  | false  | false| a1::q1 | topic | 0 |
   | a1  | q1  | Anycast| false  | false  | a1::q1 | queue | 0 |
   
   If we create a queue based on FQQN, only if the queue doesn't exist, we 
wouldn't break any existing users, as they are using FQQN to attach to 
pre-configured queues anyway. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 437381)
    Time Spent: 10h  (was: 9h 50m)

> Create queues for AMQP clients based on FQQN
> --------------------------------------------
>
>                 Key: ARTEMIS-2614
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2614
>             Project: ActiveMQ Artemis
>          Issue Type: New Feature
>          Components: AMQP
>            Reporter: Krzysztof Porębski
>            Priority: Major
>          Time Spent: 10h
>  Remaining Estimate: 0h
>
> As a follow up to the discussion on the mailing list I would like to suggest 
> a new feature regarding FQQN implementation for AMQP protocol - creating 
> queues.
> Currently there is no way of attaching to a queue using FQQN if the queue is 
> not configured upfront. It should be changed so it would be possible to 
> create queue via FQQN and a subset of the following capabilities:
> - shared
> - topic
> - queue



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to