[
https://issues.apache.org/jira/browse/ARTEMIS-2815?focusedWorklogId=449074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-449074
]
ASF GitHub Bot logged work on ARTEMIS-2815:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/20 08:27
Start Date: 22/Jun/20 08:27
Worklog Time Spent: 10m
Work Description: michaelpearce-gain edited a comment on pull request
#3195:
URL: https://github.com/apache/activemq-artemis/pull/3195#issuecomment-647366360
> BTW, what's about with this -->
>
>
https://github.com/apache/activemq-artemis/blob/4e77a9fb79503af017695c0955438517450c0d50/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java#L3965-L3966
This is because the QueueImpl doesnt support LVQ (theres a special extended
version, as such its not possible atm to update (you have to remove and re add
a queue currently) This is something though that could be rolled into a single
queue, and make it updateable, i had a poc a while back, just never got time to
finish it. And no one is shouting for it so like all things prioritised down.
I can re-pick it up, if you have a need to switch from LVQ to normal queue
and back, without distruction.
In particular to the setLastValue(null), that should be
setLastValueKey(null) thats just a mistake in the move to queueConfig recently,
feel free to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 449074)
Time Spent: 1h 40m (was: 1.5h)
> Null pointer exception on queue update
> --------------------------------------
>
> Key: ARTEMIS-2815
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2815
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.13.0
> Reporter: Krzysztof Porębski
> Assignee: Krzysztof Porębski
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Null pointer exception is thrown on the attempt to update a queue created
> without a filter.
> The problem is with getQueueConfiguration method in QueueImpl class. There is
> no check if filter is null before getFilterString is invoked.
> {code:java}
> @Override
> public QueueConfiguration getQueueConfiguration() {
> return new QueueConfiguration(name)
> .setAddress(address)
> .setId(id)
> .setRoutingType(routingType)
> .setFilterString(filter.getFilterString())
> .setDurable(isDurable())
> .setUser(user)
> .setMaxConsumers(maxConsumers)
> .setExclusive(exclusive)
> .setGroupRebalance(groupRebalance)
> .setGroupBuckets(groupBuckets)
> .setGroupFirstKey(groupFirstKey)
> .setLastValue(false)
> .setLastValue(null)
> .setNonDestructive(nonDestructive)
> .setPurgeOnNoConsumers(purgeOnNoConsumers)
> .setConsumersBeforeDispatch(consumersBeforeDispatch)
> .setDelayBeforeDispatch(delayBeforeDispatch)
> .setAutoDelete(autoDelete)
> .setAutoDeleteDelay(autoDeleteDelay)
> .setAutoDeleteMessageCount(autoDeleteMessageCount)
> .setRingSize(ringSize)
> .setConfigurationManaged(configurationManaged)
> .setTemporary(temporary)
> .setInternal(internalQueue)
> .setTransient(refCountForConsumers instanceof TransientQueueManagerImpl)
> .setAutoCreated(autoCreated);
> }{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
